Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752188Ab2BHN6t (ORCPT ); Wed, 8 Feb 2012 08:58:49 -0500 Received: from mail1.windriver.com ([147.11.146.13]:57967 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752Ab2BHN6s (ORCPT ); Wed, 8 Feb 2012 08:58:48 -0500 Message-ID: <4F327F74.6080106@windriver.com> Date: Wed, 8 Feb 2012 08:58:12 -0500 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111109 Thunderbird/3.1.16 MIME-Version: 1.0 To: Jiri Slaby CC: Alan Cox , Sam Ravnborg , Arnd Bergmann , Greg Kroah-Hartman , Jiri Slaby , , Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/ References: <1325707287-31038-1-git-send-email-paul.gortmaker@windriver.com> <4F04BFA8.9010100@windriver.com> <20120104220332.GA22985@suse.de> <201201042327.33739.arnd@arndb.de> <20120105054240.GA9093@merkur.ravnborg.org> <20120105124505.73c88f2c@bob.linux.org.uk> <20120105232142.GA10870@windriver.com> <4F324ECB.7040102@gmail.com> <4F324F4B.3090500@gmail.com> In-Reply-To: <4F324F4B.3090500@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.146.65] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2598 Lines: 67 On 12-02-08 05:32 AM, Jiri Slaby wrote: > Damnit! They didn't manage to forward Greg's email. What a crap. > > On 02/08/2012 11:30 AM, Jiri Slaby wrote: >> On 01/06/2012 12:21 AM, Paul Gortmaker wrote: >>> --- /dev/null >>> +++ b/drivers/tty/serial/8250/Makefile >>> @@ -0,0 +1,20 @@ >>> +# >>> +# Makefile for the 8250 serial device drivers. >>> +# >>> + >>> +obj-$(CONFIG_SERIAL_8250) += 8250.o >>> +obj-$(CONFIG_SERIAL_8250_PNP) += 8250_pnp.o >>> +obj-$(CONFIG_SERIAL_8250_GSC) += 8250_gsc.o >>> +obj-$(CONFIG_SERIAL_8250_PCI) += 8250_pci.o >>> +obj-$(CONFIG_SERIAL_8250_HP300) += 8250_hp300.o >>> +obj-$(CONFIG_SERIAL_8250_CS) += serial_cs.o >>> +obj-$(CONFIG_SERIAL_8250_ACORN) += 8250_acorn.o >>> +obj-$(CONFIG_SERIAL_8250_CONSOLE) += 8250_early.o >>> +obj-$(CONFIG_SERIAL_8250_FOURPORT) += 8250_fourport.o >>> +obj-$(CONFIG_SERIAL_8250_ACCENT) += 8250_accent.o >>> +obj-$(CONFIG_SERIAL_8250_BOCA) += 8250_boca.o >>> +obj-$(CONFIG_SERIAL_8250_EXAR_ST16C554) += 8250_exar_st16c554.o >>> +obj-$(CONFIG_SERIAL_8250_HUB6) += 8250_hub6.o >>> +obj-$(CONFIG_SERIAL_8250_MCA) += 8250_mca.o >>> +obj-$(CONFIG_SERIAL_8250_FSL) += 8250_fsl.o >>> +obj-$(CONFIG_SERIAL_8250_DW) += 8250_dw.o >> >> ... >> >>> diff --git a/drivers/tty/serial/m32r_sio.c b/drivers/tty/serial/8250/m32r_sio.c >>> similarity index 100% >>> rename from drivers/tty/serial/m32r_sio.c >>> rename to drivers/tty/serial/8250/m32r_sio.c >>> diff --git a/drivers/tty/serial/m32r_sio.h b/drivers/tty/serial/8250/m32r_sio.h >>> similarity index 100% >>> rename from drivers/tty/serial/m32r_sio.h >>> rename to drivers/tty/serial/8250/m32r_sio.h >>> diff --git a/drivers/tty/serial/m32r_sio_reg.h b/drivers/tty/serial/8250/m32r_sio_reg.h >>> similarity index 100% >>> rename from drivers/tty/serial/m32r_sio_reg.h >>> rename to drivers/tty/serial/8250/m32r_sio_reg.h >> >> Hmm, these cannot be built now :(. Why did you move them? As near as I can tell, I think I got misled by the comment in the m32r register file: * These are the UART port assignments, expressed as offsets from the base * register. These assignments should hold for any serial port based on * a 8250, 16450, or 16550(A). But you are right, they should not have been caught up in the move. I'll send a fix... Sorry about the hassle. P. >> >> It looks like they should be moved back. >> >> regards, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/