Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753964Ab2BHUYe (ORCPT ); Wed, 8 Feb 2012 15:24:34 -0500 Received: from usindpps06.hds.com ([207.126.252.19]:54421 "EHLO usindpps06.hds.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429Ab2BHUYb convert rfc822-to-8bit (ORCPT ); Wed, 8 Feb 2012 15:24:31 -0500 From: Seiji Aguchi To: Matthew Garrett , "linux-kernel@vger.kernel.org" CC: "dzickus@redhat.com" , "vgoyal@redhat.com" Date: Wed, 8 Feb 2012 15:24:27 -0500 Subject: RE: [PATCH] kmsg_dump: Don't run on non-error paths by default Thread-Topic: [PATCH] kmsg_dump: Don't run on non-error paths by default Thread-Index: AczmfLtegkfkAG8LSzuvfQiENX9I+QAIrQhA Message-ID: <5C4C569E8A4B9B42A84A977CF070A35B2DAC650D07@USINDEVS01.corp.hds.com> References: <1328717646-17121-1-git-send-email-mjg@redhat.com> In-Reply-To: <1328717646-17121-1-git-send-email-mjg@redhat.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: ja-JP, en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 spamscore=0 ipscore=0 suspectscore=2 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1202080206 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3056 Lines: 75 This patch, introducing tunable parameter, is reasonable to me. Acked-by: Seiji Aguchi -----Original Message----- From: Matthew Garrett [mailto:mjg@redhat.com] Sent: Wednesday, February 08, 2012 11:14 AM To: linux-kernel@vger.kernel.org Cc: Seiji Aguchi; dzickus@redhat.com; vgoyal@redhat.com; Matthew Garrett Subject: [PATCH] kmsg_dump: Don't run on non-error paths by default Since 04c6862c055fb687c90d9652f32c11a063df15cf kmsg_dump() gets run on normal paths including poweroff and reboot. This is less than ideal given pstore implementations that can only represent single backtraces, since a reboot may overwrite a stored oops before it's been picked up by userspace. In addition, some pstore backends may have low performance and provide a significant delay in reboot as a result. This patch adds a printk.always_kmsg_dump kernel parameter (which can also be changed from userspace). Without it, the code will only be run on failure paths rather than on normal paths. The option can be enabled in environments where there's a desire to attempt to audit whether or not a reboot was cleanly requested or not. Signed-off-by: Matthew Garrett --- include/linux/kmsg_dump.h | 9 +++++++-- kernel/printk.c | 6 ++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/kmsg_dump.h b/include/linux/kmsg_dump.h index fee6631..35f7237 100644 --- a/include/linux/kmsg_dump.h +++ b/include/linux/kmsg_dump.h @@ -15,13 +15,18 @@ #include #include +/* + * Keep this list arranged in rough order of priority. Anything listed +after + * KMSG_DUMP_OOPS will not be logged by default unless +printk.always_kmsg_dump + * is passed to the kernel. + */ enum kmsg_dump_reason { - KMSG_DUMP_OOPS, KMSG_DUMP_PANIC, + KMSG_DUMP_OOPS, + KMSG_DUMP_EMERG, KMSG_DUMP_RESTART, KMSG_DUMP_HALT, KMSG_DUMP_POWEROFF, - KMSG_DUMP_EMERG, }; /** diff --git a/kernel/printk.c b/kernel/printk.c index 13c0a11..e7d07f5 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -702,6 +702,9 @@ static bool printk_time = 0; #endif module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); +static bool always_kmsg_dump; +module_param_named(always_kmsg_dump, always_kmsg_dump, bool, S_IRUGO | +S_IWUSR); + /* Check if we have any console registered that can be called early in boot. */ static int have_callable_console(void) { @@ -1732,6 +1735,9 @@ void kmsg_dump(enum kmsg_dump_reason reason) unsigned long l1, l2; unsigned long flags; + if (reason > KMSG_DUMP_PANIC && !always_kmsg_dump) + return; + /* Theoretically, the log could move on after we do this, but there's not a lot we can do about that. The new messages will overwrite the start of what we dump. */ -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/