Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757537Ab2BHW63 (ORCPT ); Wed, 8 Feb 2012 17:58:29 -0500 Received: from mail.vyatta.com ([76.74.103.46]:40976 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754828Ab2BHW60 (ORCPT ); Wed, 8 Feb 2012 17:58:26 -0500 Date: Wed, 8 Feb 2012 14:58:23 -0800 From: Stephen Hemminger To: Danny Kukawka Cc: "David S. Miller" , Danny Kukawka , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice Message-ID: <20120208145823.75f386c5@nehalam.linuxnetplumber.net> In-Reply-To: <1328735457-29986-1-git-send-email-danny.kukawka@bisect.de> References: <1328735457-29986-1-git-send-email-danny.kukawka@bisect.de> Organization: Vyatta X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.8; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 38 On Wed, 8 Feb 2012 22:10:07 +0100 Danny Kukawka wrote: > The information if a device has a random MAC address is exported > to the userspace via /sys/class/net/*/addr_assign_type, which > export net_device->addr_assign_type. > > Currently only a few driver really use dev_hw_addr_random() to > set addr_assign_type correctly to NET_ADDR_RANDOM. > > This patch change the drivers which set random addresses to > change also addr_assign_type to NET_ADDR_RANDOM. > > To reflect if the MAC was changed from userspace via SIOCSIFHWADDR, > which means it's no longer a random address set by the kernel, > this patch remove NET_ADDR_RANDOM from addr_assign_type in this > case. > > With this patch tools from userspace can now detect devices with > random MAC addresses and change them to persistent addresses if > needed (as e.g. in case of smsc95xx on PandaBoard). > > Maybe it makes sense to introduce a new state for addr_assign_type > to reflect the fact, that the MAC address was changed via a ioctl > from user space, e.g, with NET_ADDR_USERSPACE ? > This reminds me that passing dev->dev_addr to dev_hw_addr_rrandom is redundant for all the instances you showed, so why is it ia parameter. Also it should BUG() if address length is not 6 (ETH_ALEN). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/