Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374Ab2BIF02 (ORCPT ); Thu, 9 Feb 2012 00:26:28 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:44372 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605Ab2BIF01 convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2012 00:26:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <20120207.091612.181444339.anemo@mba.ocn.ne.jp> Date: Thu, 9 Feb 2012 00:26:25 -0500 Message-ID: Subject: Re: kconfig: tristate choice with depender choice From: Arnaud Lacombe To: Atsushi Nemoto Cc: Michal Marek , Sam Ravnborg , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1663 Lines: 65 Hi, On Thu, Feb 9, 2012 at 12:08 AM, Arnaud Lacombe wrote: > Hi, > > On Mon, Feb 6, 2012 at 7:16 PM, Atsushi Nemoto wrote: >> If a tristate choice has another choice dependers, kconfig produce >> wrong value. >> >> Example: >> >> choice >> ? ? ? ?prompt "choice list AB" >> config A >> ? ? ? ?tristate "a" >> config B >> ? ? ? ?tristate "b" >> endchoice >> choice >> ? ? ? ?prompt "choice list CD" >> ? ? ? ?depends on A >> config C >> ? ? ? ?bool "c" >> config D >> ? ? ? ?bool "d" >> endchoice >> >> kconfig outputs CONFIG_A=m from defconfig with CONFIG_A=y. >> >> This happens if the choice list CD depends on A. >> Also, if defconfig contains CONFIG_A=y and "# CONFIG_B is not set", >> output is correct. >> > confirmed. > actually, not that much. Your reduced testcase is missing a MODULES symbol to have modules enabled and have them show up in the final `.config'. If you add: config MODULES boolean default y then you end up with CONFIG_A=m in the `.config'. Now, I may have missed something. Do you have a situation where a MODULES symbol is present, enabled, but CONFIG_A=y still appear from CONFIG_A=m in the defconfig ? Thanks, - Arnaud >> I found commit a64b44ea ("kconfig: fix tristate choice with minimal >> config"), but this problem still exists on v3.3-rc1. ?More fix is >> needed for choice with dependers? >> > it would seem so. > > ?- Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/