Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757575Ab2BINhq (ORCPT ); Thu, 9 Feb 2012 08:37:46 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:46298 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753701Ab2BINhp (ORCPT ); Thu, 9 Feb 2012 08:37:45 -0500 Message-ID: <4F33CC1E.7090403@pengutronix.de> Date: Thu, 09 Feb 2012 14:37:34 +0100 From: Marc Kleine-Budde Organization: Pengutronix User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: "Arnaud Patard (Rtp)" CC: Mikael Pettersson , Marc Kleine-Budde , Imre Kaloz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Halasa Subject: Re: [PATCH 1/2] ARM: ixp4xx: fix compilation, add gpiolib support References: <1328729069-21308-1-git-send-email-mkl@blackshift.org> <1328729069-21308-2-git-send-email-mkl@blackshift.org> <20275.35898.120590.54388@pilspetsen.it.uu.se> <87fweki8aa.fsf@lebrac.rtp-net.org> In-Reply-To: <87fweki8aa.fsf@lebrac.rtp-net.org> X-Enigmail-Version: 1.3.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig69E66737257FFCBDC2CF659F" X-SA-Exim-Connect-IP: 2001:6f8:1178:4:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2872 Lines: 75 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig69E66737257FFCBDC2CF659F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/09/2012 11:57 AM, Arnaud Patard (Rtp) wrote: > Mikael Pettersson writes: >=20 >> Marc Kleine-Budde writes: >> > From: Imre Kaloz >> >=20 >> > The problem was introduced with commit: >> > "eb9ae7f gpio: fix build error in include/asm-generic/gpio.h" >> >=20 >> > This patch adds gpiolib support for the IXP4xx platform, which fixe= s the >> > compilation of several ixp4xx platforms, e.g.: >> >=20 >> > In file included from arch/arm/mach-ixp4xx/include/mach/gpio.h:72, >> > from /home/frogger/projects/server/linux/arch/arm/= include/asm/gpio.h:9, >> > from include/linux/gpio.h:30, >> > from arch/arm/mach-ixp4xx/nslu2-setup.c:19: >> > include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep': >> > include/asm-generic/gpio.h:218: error: implicit declaration of func= tion '__gpio_get_value' >> > include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep': >> > include/asm-generic/gpio.h:224: error: implicit declaration of func= tion '__gpio_set_value' >> >> This fix is needed for 3.2 too, right? I got the same errors when >> updating my (out-of-tree) ixp4xx/ds101 platform support to the 3.2 ker= nel >> a few days ago. >=20 > fwiw, it's even needed for 3.1. We've added it in the debian kernel whe= n it > was sent to the linux-arm-kernel ml and it was for 3.1. Yep v3.1.10 fails in drivers/input/touchscreen/ads7846.c with: drivers/input/touchscreen/ads7846.c: In function 'ads7846_setup_pendown':= drivers/input/touchscreen/ads7846.c:970: error: implicit declaration of function 'gpio_request_one' Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig69E66737257FFCBDC2CF659F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8zzCQACgkQjTAFq1RaXHPWqwCdHn1Q/gFQS/Mo5RIg0YRCkcCb FQ8Anih2RUixsgDxthVdlKtNRB8b/07T =wMDQ -----END PGP SIGNATURE----- --------------enig69E66737257FFCBDC2CF659F-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/