Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757416Ab2BIOpA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Feb 2012 09:45:00 -0500
Received: from mail-gy0-f174.google.com ([209.85.160.174]:62799 "EHLO
	mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752704Ab2BIOo7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Feb 2012 09:44:59 -0500
Date: Thu, 9 Feb 2012 12:44:51 -0200
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@gmail.com>,
        linux-kernel@vger.kernel.org, peterz@infradead.org, fweisbec@gmail.com,
        paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH] perf tools: Allow multiple threads or processes in
 record, stat, top
Message-ID: <20120209144451.GB2526@infradead.org>
References: <1328718772-16688-1-git-send-email-dsahern@gmail.com>
 <4F331F14.5070100@gmail.com>
 <4F3334F7.70809@gmail.com>
 <20120209073727.GA18152@elte.hu>
 <20120209143449.GA2526@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120209143449.GA2526@infradead.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1513
Lines: 39

Em Thu, Feb 09, 2012 at 12:34:49PM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 09, 2012 at 08:37:27AM +0100, Ingo Molnar escreveu:
> > 
> > * David Ahern <dsahern@gmail.com> wrote:
> > 
> > > > I was trying to remove ctype.h, you might use util.h here.
> > > 
> > > Right, knew that. But, in this case I am adding a call to 
> > > isdigit which means a direct dependency on ctype.h. I would 
> > > prefer a direct relationship versus an indirect via util.h
> > 
> > Please just remove ctype.h *altogether* from perf, it's just an 
> > insane header.
> > 
> > Have a look at how Git solves these types of problems, it 
> > defines sane string functions in git-compat-util.h:
> 
> Yeah, these are in util.h, that doesn't includes ctype.h
> 
> I'm fixing this up and also that s/UUID/UID/g Kim pointed out,
> then testing if the python binding still is ok with these changes.

[root@aninha linux]# tools/perf/python/twatch.py 
Traceback (most recent call last):
  File "tools/perf/python/twatch.py", line 16, in <module>
    import perf
ImportError: /home/acme/git/build/perf/python/perf.so: undefined symbol:
ui__error
[root@aninha linux]#

it breaks, I'll check an alternative way to report problems without
calling ui__ methods from thread_map.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/