Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758045Ab2BIQEd (ORCPT ); Thu, 9 Feb 2012 11:04:33 -0500 Received: from acsinet15.oracle.com ([141.146.126.227]:60425 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285Ab2BIQEa convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2012 11:04:30 -0500 Date: Thu, 9 Feb 2012 11:01:28 -0500 From: Konrad Rzeszutek Wilk To: Tang Liang Cc: mjg59@srcf.ucam.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/5] EFI: Provide registration for efi_init.. etc efi public function Message-ID: <20120209160128.GA32058@phenom.dumpdata.com> References: <1328758250-23989-1-git-send-email-liang.tang@oracle.com> <1328758328-24156-1-git-send-email-liang.tang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1328758328-24156-1-git-send-email-liang.tang@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-CT-RefId: str=0001.0A090202.4F33EE87.010B,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2838 Lines: 78 On Thu, Feb 09, 2012 at 11:32:08AM +0800, Tang Liang wrote: > The efi public functions are changed to function pointer in efi_init_funcs > struct. > They act as efi generic functions as default. > As a benefit from this change, we can register xen efi init func. > > Signed-off-by: Tang Liang > --- > arch/x86/platform/efi/efi.c | 65 +++++++++++++++++++++++++++++++++++++++--- > include/linux/efi.h | 12 +++++++- > 2 files changed, 71 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > index 4cf9bd0..d567e29 100644 > --- a/arch/x86/platform/efi/efi.c > +++ b/arch/x86/platform/efi/efi.c > @@ -50,6 +50,23 @@ > #define PFX "EFI: " > > int efi_enabled; > + > +static void efi_init_generic(void); > + > +static void efi_enter_virtual_mode_generic(void); > +static u32 efi_mem_type_generic(unsigned long phys_addr); > +static u64 efi_mem_attributes_generic(unsigned long phys_addr); > + > +struct efi_init_funcs efi_generic_funcs = { > + .__efi_init = efi_init_generic, > + .__efi_reserve_boot_services = efi_reserve_boot_services_generic, Hmm, did you compile test this? I get: /home/konrad/ssd/linux/arch/x86/platform/efi/efi.c:62: error: ‘efi_reserve_boot_services_generic’ undeclared here (not in a function) The patch below fixes it: >From 6ecdc001b99f06f73fe55ea24663c9a3921c285e Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Thu, 9 Feb 2012 10:59:17 -0500 Subject: [PATCH] efi: Fix compiler error introduced by moving of the code decleration. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The compiler error is : arch/x86/platform/efi/efi.c:62: error: ‘efi_reserve_boot_services_generic’ undeclared here (not in a function And declearing it before the use fixes the issue. Signed-off-by: Konrad Rzeszutek Wilk --- arch/x86/platform/efi/efi.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index d7b19ee..c21b325 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -56,6 +56,7 @@ static void efi_init_generic(void); static void efi_enter_virtual_mode_generic(void); static u32 efi_mem_type_generic(unsigned long phys_addr); static u64 efi_mem_attributes_generic(unsigned long phys_addr); +static void efi_reserve_boot_services_generic(void); struct efi_init_funcs efi_generic_funcs = { .__efi_init = efi_init_generic, -- 1.7.7.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/