Message-ID: <4F3400DF.9080603@suse.com>
Date: Thu, 09 Feb 2012 09:22:39 -0800
From: Lee Duncan <lduncan@suse.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SCSI, st: modify tape driver to allow writing immediate
 filemarks
References: <4F31CAC0.3010905@suse.com> <1328663723.27428.2.camel@joe2Laptop>
In-Reply-To: <1328663723.27428.2.camel@joe2Laptop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1702
Lines: 49

Hi Joe:

Thanks for the quick review.

On 02/07/2012 05:15 PM, Joe Perches wrote:
> On Tue, 2012-02-07 at 17:07 -0800, Lee Duncan wrote:
>> Add an st module option st_nowait_eof which defaults to 0. Setting this
>> option to 1 tells the st driver not to wait when writing a filemark, which
>> can result in much faster times on streaming tape drives.
> 
> trivial comments:
> 
>> diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
> []
>> @@ -81,6 +81,7 @@ static int max_sg_segs;
>>  static int try_direct_io = TRY_DIRECT_IO;
>>  static int try_rdio = 1;
>>  static int try_wdio = 1;
>> +static int st_nowait_eof = 0;
> 
> Could be bool.

In both this case and the one you site below, the existing variables are
not bool. I'd rather see new variables match existing variables, in
naming, type, and usage. Next major update of the driver, I'd like to
see all of these bools-in-use fixed.

> 
>> @@ -1106,6 +1109,11 @@ static int check_tape(struct scsi_tape *STp, struct file *filp)
>>                                      STp->drv_buffer));
>>  		}
>>  		STp->drv_write_prot = ((STp->buffer)->b_data[2] & 0x80) != 0;
>> +		if (!STp->drv_buffer && STp->immediate_filemark) {
>> +			printk(KERN_WARNING "%s: non-buffered tape: "
>> +			    "disabling writing immediate filemarks", name);
> 
> Needs terminating "\n" and it's better to coalesce the
> format and ignore 80 char lines to make arbitrary greps
> a bit easier.

Good catch. Thanks.

-- 
Lee Duncan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/