Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757888Ab2BJQfX (ORCPT ); Fri, 10 Feb 2012 11:35:23 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:64674 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753916Ab2BJQfW convert rfc822-to-8bit (ORCPT ); Fri, 10 Feb 2012 11:35:22 -0500 MIME-Version: 1.0 In-Reply-To: <20120210155753.GA25923@redhat.com> References: <1328884991-23889-1-git-send-email-vda.linux@googlemail.com> <1328884991-23889-2-git-send-email-vda.linux@googlemail.com> <1328884991-23889-3-git-send-email-vda.linux@googlemail.com> <1328884991-23889-4-git-send-email-vda.linux@googlemail.com> <20120210155753.GA25923@redhat.com> From: Denys Vlasenko Date: Fri, 10 Feb 2012 17:34:33 +0100 Message-ID: Subject: Re: [PATCH 3/5] ptrace: make PTRACE_SEIZE set ptrace options specified in 'data' parameter To: Oleg Nesterov Cc: Andrew Morton , Tejun Heo , Pedro Alves , Jan Kratochvil , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 22 On Fri, Feb 10, 2012 at 4:57 PM, Oleg Nesterov wrote: > On 02/10, Denys Vlasenko wrote: >> >> @@ -879,7 +890,7 @@ SYSCALL_DEFINE4(ptrace, long, request, long, pid, unsigned long, addr, >> ? ? ? } >> >> ? ? ? if (request == PTRACE_ATTACH || request == PTRACE_SEIZE) { >> - ? ? ? ? ? ? ret = ptrace_attach(child, request, data); >> + ? ? ? ? ? ? ret = ptrace_attach(child, request, addr, data); > > There is another caller which should be updated, sys_compat_ptrace(). Drats. I only tested the patch on i386, not on x86-64, and missed it. Updated patch follows in a minute. -- vda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/