Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377Ab2BKPuJ (ORCPT ); Sat, 11 Feb 2012 10:50:09 -0500 Received: from kamaji.grokhost.net ([87.117.218.43]:52209 "EHLO kamaji.grokhost.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754843Ab2BKPuI (ORCPT ); Sat, 11 Feb 2012 10:50:08 -0500 Message-ID: <4F368E22.30500@bootc.net> Date: Sat, 11 Feb 2012 15:49:54 +0000 From: Chris Boot User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Clemens Ladisch CC: Stefan Richter , Greg KH , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] firewire-sbp2: Ignore SBP-2 targets on the local node References: <1328881314-26544-1-git-send-email-bootc@bootc.net> <1328881314-26544-3-git-send-email-bootc@bootc.net> <20120211122832.25f00d59@stein> <4F365C01.6000807@ladisch.de> <4F365FA8.40600@bootc.net> <4F368D6F.90702@ladisch.de> In-Reply-To: <4F368D6F.90702@ladisch.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 49 On 11/02/2012 15:46, Clemens Ladisch wrote: > Chris Boot wrote: >> On 11/02/2012 12:16, Clemens Ladisch wrote: >>> Stefan Richter wrote: >>>> On Feb 10 Chris Boot wrote: >>>>> + /* ignore targets on the local node */ >>>>> + if (device->node == device->card->local_node) { >>>>> + dev_set_drvdata(&unit->device, NULL); >>>>> + return 0; >>>>> + } >>>> >>>> But I do wonder: Shouldn't this be implemented by returning from the >>>> driver probe method with an error? If so, which errno should be returned? >>> >>> -ENODEV or -ENXIO. >> >> Perhaps, > > It's what really_probe() in drivers/base/dd.c requires: > > if (ret != -ENODEV&& ret != -ENXIO) { > /* driver matched but the probe failed */ > printk(KERN_WARNING > "%s: probe of %s failed with error %d\n", > drv->name, dev_name(dev), ret); > } else { > pr_debug("%s: probe of %s rejects match %d\n", > drv->name, dev_name(dev), ret); > } > >> but the meaning of those isn't quite what is happening here. We aren't >> saying the device doesn't exist or is inaccessible, just that we don't >> want to talk to it... > > ENODEV does not mean "no device" but "no _such_ device". Sounds fair. I'll update my patch. Cheers, Chris -- Chris Boot bootc@bootc.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/