Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662Ab2BLLXI (ORCPT ); Sun, 12 Feb 2012 06:23:08 -0500 Received: from mail.skyhub.de ([78.46.96.112]:46402 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856Ab2BLLXG (ORCPT ); Sun, 12 Feb 2012 06:23:06 -0500 Date: Sun, 12 Feb 2012 12:23:06 +0100 From: Borislav Petkov To: Kevin Winchester Cc: Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Randy Dunlap , Nick Bowler , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Move per cpu cpu_llc_shared_map to a field in struct cpuinfo_x86 Message-ID: <20120212112306.GA14593@x1.osrc.amd.com> Mail-Followup-To: Borislav Petkov , Kevin Winchester , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Randy Dunlap , Nick Bowler , linux-kernel@vger.kernel.org References: <20120211140737.GA26637@elte.hu> <1329006252-1684-1-git-send-email-kjwinchester@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1444 Lines: 36 On Sat, Feb 11, 2012 at 10:18:53PM -0400, Kevin Winchester wrote: > > @@ -225,7 +225,6 @@ static void __init xen_smp_prepare_cpus(unsigned int max_cpus) > >        for_each_possible_cpu(i) { > >                zalloc_cpumask_var(&per_cpu(cpu_sibling_map, i), GFP_KERNEL); > >                zalloc_cpumask_var(&per_cpu(cpu_core_map, i), GFP_KERNEL); > > -               zalloc_cpumask_var(&per_cpu(cpu_llc_shared_map, i), GFP_KERNEL); > >        } > >        set_cpu_sibling_map(0); > > > > I just realized that I took out a couple of allocations here for > cpu_llc_shared_map, without replacing them. Am I leaving > cpuinfo_x86.llc_shared_map unallocated then, and just writing to > whatever address that field happened to get? AFAICT, yes, you need to alloc the cpumask too, i.e. something like zalloc_cpumask_var(cpu_info(i).llc_shared_map, GFP_KERNEL); assuming this happens before the cpumask gets initted in set_cpu_sibling_map() et al. Just give the whole init path a hard staring, and try to figure out the proper init sequence. HTH. P.S.: I'm currently travelling but will give your patch a run when I get back, thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/