Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449Ab2BMFcP (ORCPT ); Mon, 13 Feb 2012 00:32:15 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:50761 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775Ab2BMFcO (ORCPT ); Mon, 13 Feb 2012 00:32:14 -0500 Date: Sun, 12 Feb 2012 22:32:08 -0700 Subject: Re: [PATCH 3/3] KVM: perf: kvm events analysis tool Message-ID: From: David Ahern To: Xiao Guangrong Cc: Avi Kivity , Marcelo Tosatti , Ingo Molnar , Arnaldo Carvalho de Melo , LKML , KVM MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q1D5WLhp032195 Content-Length: 2863 Lines: 61 [sorry for the top post - you would think Android would have a better mail client] If the first patch is needed then kvm-events will not work with older, unpatched kernels. That's a big limitation from a perf perpective. David Sent from my ASUS Eee Pad Xiao Guangrong wrote: >On 02/13/2012 11:04 AM, David Ahern wrote: > >> Compile fails on Fedora 16, x86_64 with latest tip-perf-core branch: >> >> >> In file included from builtin-kvm-events.c:19:0: >> ../../arch/x86/include/asm/svm.h:133:1: error: packed attribute is >> unnecessary for ‘vmcb_seg’ [-Werror=packed] >> ../../arch/x86/include/asm/svm.h:178:1: error: packed attribute is >> unnecessary for ‘vmcb_save_area’ [-Werror=packed] >> ../../arch/x86/include/asm/svm.h:183:1: error: packed attribute is >> unnecessary for ‘vmcb’ [-Werror=packed] >> In file included from builtin-kvm-events.c:20:0: >> ../../arch/x86/include/asm/vmx.h:334:0: error: "REG_R8" redefined [-Werror] >> /usr/include/sys/ucontext.h:46:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:335:0: error: "REG_R9" redefined [-Werror] >> /usr/include/sys/ucontext.h:48:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:336:0: error: "REG_R10" redefined [-Werror] >> /usr/include/sys/ucontext.h:50:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:337:0: error: "REG_R11" redefined [-Werror] >> /usr/include/sys/ucontext.h:52:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:338:0: error: "REG_R12" redefined [-Werror] >> /usr/include/sys/ucontext.h:54:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:339:0: error: "REG_R13" redefined [-Werror] >> /usr/include/sys/ucontext.h:56:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:340:0: error: "REG_R14" redefined [-Werror] >> /usr/include/sys/ucontext.h:58:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:341:0: error: "REG_R15" redefined [-Werror] >> /usr/include/sys/ucontext.h:60:0: note: this is the location of the >> previous definition >> ../../arch/x86/include/asm/vmx.h:443:13: error: expected declaration >> specifiers or ‘...’ before numeric constant >> In file included from builtin-kvm-events.c:21:0: >> ../../arch/x86/include/asm/kvm_host.h:15:22: fatal error: linux/mm.h: No >> such file or directory >> cc1: all warnings being treated as errors >> > > >The first patch(patch 1/3) should be applied! > >Thank you, David! :) > ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?