Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753383Ab2BMGjw (ORCPT ); Mon, 13 Feb 2012 01:39:52 -0500 Received: from senator.holtmann.net ([87.106.208.187]:39346 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277Ab2BMGju (ORCPT ); Mon, 13 Feb 2012 01:39:50 -0500 Message-ID: <1329115057.28848.52.camel@aeonflux> Subject: Re: [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug From: Marcel Holtmann To: Joe Perches Cc: "Gustavo F. Padovan" , "David S. Miller" , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Mon, 13 Feb 2012 07:37:37 +0100 In-Reply-To: <90fbd8a0b800c83f5ad1df7889dc9b11d7d9c588.1329102581.git.joe@perches.com> References: <90fbd8a0b800c83f5ad1df7889dc9b11d7d9c588.1329102581.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 23 Hi Joe, > No need to obfuscate, just use the normal debugging macro. > > Add "\n" to uses, align arguments, coalesce formats. > Fix a typo and fix a bad format extended by a line continuation. what is this patch buying us. Nothing at all. I rather not do this and leave BT_DBG in it. The only useful change would be to move to dev_printk, but we are not there yet. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/