Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755274Ab2BMMIY (ORCPT ); Mon, 13 Feb 2012 07:08:24 -0500 Received: from na3sys009aog115.obsmtp.com ([74.125.149.238]:37942 "EHLO na3sys009aog115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335Ab2BMMIW (ORCPT ); Mon, 13 Feb 2012 07:08:22 -0500 Date: Mon, 13 Feb 2012 14:08:15 +0200 From: Felipe Balbi To: Guennadi Liakhovetski Cc: linux-usb@vger.kernel.org, Felipe Balbi , "Shimoda, Yoshihiro" , linux-sh@vger.kernel.org, Magnus Damm , linux-kernel@vger.kernel.org, Vinod Koul , Paul Mundt Subject: Re: [PATCH 2/2] usb: fix renesas_usbhs to not schedule in atomic context Message-ID: <20120213120814.GP6614@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3mUD2hqWbnBptYHy" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2448 Lines: 67 --3mUD2hqWbnBptYHy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Feb 09, 2012 at 11:17:51PM +0100, Guennadi Liakhovetski wrote: > @@ -997,7 +991,7 @@ static bool usbhsf_dma_filter(struct dma_chan *chan, = void *param) > * > * usbhs doesn't recognize id =3D 0 as valid DMA > */ > - if (0 =3D=3D slave->slave_id) > + if (0 =3D=3D slave->simple_slave.slave_id) > return false; > =20 > chan->private =3D slave; > @@ -1176,8 +1170,8 @@ int usbhs_fifo_probe(struct usbhs_priv *priv) > fifo->port =3D D0FIFO; > fifo->sel =3D D0FIFOSEL; > fifo->ctr =3D D0FIFOCTR; > - fifo->tx_slave.slave_id =3D usbhs_get_dparam(priv, d0_tx_id); > - fifo->rx_slave.slave_id =3D usbhs_get_dparam(priv, d0_rx_id); > + fifo->tx_slave.simple_slave.slave_id =3D usbhs_get_dparam(priv, d0_tx_i= d); > + fifo->rx_slave.simple_slave.slave_id =3D usbhs_get_dparam(priv, d0_rx_i= d); what are these "simple_slave" changes ? They have nothing to do with $SUBJECT ? In fact, breaks my gadget branch. How many times does a maintainer have to ask for contributors to keep changes atomic ? One patch =3D=3D One single, self-contained, change. --=20 balbi --3mUD2hqWbnBptYHy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPOP0uAAoJEIaOsuA1yqRE/F0P/jQ050wnWxUhMybRCdZGE/33 nwbyxk9Fk2nFmRs6aIwIB3BZMp//XInhfwUtV/6jvcjYOEnhb235ev5ezCoLbpEL +IvAosBUab6+lS+w4h0YxFheDoFbnWgj+REwEuT5bz662GA+rGRofIA/hE72L1SD BSUmjqvIaKy8KVvesx1BQvfOy5/gOfoAcxwF6QDX0q/BZvJkopPV+bSPNA2Ra47l wTeGxj1hT0QZZ36+BKyA0TlMxZ+E8dOMEjahNLFlqBN657QsunbCEnWpOkmVm5rF xnQgTJ5hbGwbnVcMoZm+XJWSd1F/6uVFrUieKed17DZWmgjSUjyyuXMMP2kZvHLS ocifuqLJYRL0j5kJhefOrA0aGOmq8FhOHc2x3xbuRP7u3pIy2nHL71xx7cwNqjGG o7um6KbsP34o9xD57Use3FUEa/KacSHONDak6V+9d4l+m+y5E0XyQ3jfs8uMN8A/ iyrqGvlVUILEV4OjkwVKbKjlbcYmAWOCFZMnXqhc1jrC2aNiVaGxaJaeT3k+hP2V ZtnuTCb7VLxmECIoeD/Tj2NPnyIjfZmOhMC4WppPoYT9SguCSlS3ckwYlFf09SYu ZqXWhsblVzWIJa8Tem0ZPqRqio04VqXtB4JLAiZ0Z8ptWlsZ1lFF4IsxdaqlhTlO FvjLCFZh/8SmGjUuLEtg =GQMV -----END PGP SIGNATURE----- --3mUD2hqWbnBptYHy-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/