Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756661Ab2BMNS6 (ORCPT ); Mon, 13 Feb 2012 08:18:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34817 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771Ab2BMNS4 (ORCPT ); Mon, 13 Feb 2012 08:18:56 -0500 Date: Mon, 13 Feb 2012 15:18:48 +0200 From: "Michael S. Tsirkin" To: ronnie sahlberg Cc: Dor Laor , "Nicholas A. Bellinger" , Christian Borntraeger , James Bottomley , Paolo Bonzini , Christian Hoff , borntrae@linux.vnet.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, rusty@rustcorp.com.au, Stefan Hajnoczi , target-devel Subject: Re: Pe: [PATCH v5 1/3] virtio-scsi: first version Message-ID: <20120213131848.GD26773@redhat.com> References: <4F313526.2050907@redhat.com> <4F3390FB.80107@redhat.com> <1329077777.21613.60.camel@dabdike.int.hansenpartnership.com> <4F38B657.7060405@de.ibm.com> <4F38C27E.7030300@redhat.com> <1329136806.9333.383.camel@haakon2.linux-iscsi.org> <4F3907EB.4030402@redhat.com> <20120213130005.GB26773@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 37 On Tue, Feb 14, 2012 at 12:13:36AM +1100, ronnie sahlberg wrote: > On Tue, Feb 14, 2012 at 12:00 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 13, 2012 at 02:54:03PM +0200, Dor Laor wrote: > >> Only if you use the pci multi-function option but that kills > >> standard hot unplug > > > > It doesn't kill it as such, rather you can't unplug luns individually. > > Isnt that just a consequence of the current implementation rather than > a SCSI limitation? Yes. > A different way to do hoplug could be to flag all devices as removable > in the standard inq page then > leave the LUN there persistently and what you remove/add is not the > LUN device itself but just the media in the device. > > Instead of hot-plug remove the LUN, hot-plug becomes "media eject" or > "media insert". > The device remains present all time, you never remove it, but instead > hot-plug controls if the media is present or not. > > > This would require implementing at least START_STOP_UNIT and > PREVENT_ALLOW_MEDIUM_REMOVAL opcode emulation from SBC. > > > regards > ronnie sahlberg That would work. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/