Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932192Ab2BMTg2 (ORCPT ); Mon, 13 Feb 2012 14:36:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754752Ab2BMTg0 (ORCPT ); Mon, 13 Feb 2012 14:36:26 -0500 Date: Mon, 13 Feb 2012 14:36:15 -0500 From: Mike Snitzer To: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, James Bottomley , Hannes Reinecke , linux-kernel@vger.kernel.org Subject: Re: scsi_error: do not allow IO errors with certain ILLEGAL_REQUEST sense to be retryable Message-ID: <20120213193615.GA10349@redhat.com> References: <1322857889-2623-1-git-send-email-snitzer@redhat.com> <20111206212704.GB30719@redhat.com> <20111206224218.GA31543@redhat.com> <20120213162923.GA29578@redhat.com> <20120213181359.GA5803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1853 Lines: 48 On Mon, Feb 13 2012 at 2:16pm -0500, Martin K. Petersen wrote: > >>>>> "Mike" == Mike Snitzer writes: > > >> I don't have a fundamental problem with your patch. But since we > >> explicitly handle ILLEGAL REQUEST with 0x20 and 0x24 in sd.c I wonder > >> what's broken? We should disable discard support if the WRITE SAME w/ > >> UNMAP fails. > > Mike> Yeah, I thought the disabling would be sufficient too. But > Mike> unfortunately multipath doesn't inspect the request it is retrying > Mike> (after it fails the path the request just failed on). > > Well, we shouldn't be returning something that multipath should ever act > on. > > I think I understand what's going on. Can you try the following patch? Looks good to me (small nit below), it'll solve the immediate problem, I'll pass it on. Please add my: Acked-by: Mike Snitzer But I also think establishing a baseline of TARGET_ERROR for certain ILLEGAL REQUEST is still sane and should go in too... Thanks, Mike > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index b2c95db..4e8d0b6 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -879,6 +879,7 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes) > cmd->cmnd[0] == WRITE_SAME_16 || > cmd->cmnd[0] == WRITE_SAME)) { > description = "Discard failure"; > + error = -EREMOTEIO; > action = ACTION_FAIL; Previous DIX -EILSEQ code block sets error after action. Should follow that order here? Purely an aesthetics thing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/