Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932239Ab2BMTi5 (ORCPT ); Mon, 13 Feb 2012 14:38:57 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:35873 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932203Ab2BMTiz (ORCPT ); Mon, 13 Feb 2012 14:38:55 -0500 Message-ID: <1329161933.20751.31.camel@dabdike> Subject: Re: scsi_error: do not allow IO errors with certain ILLEGAL_REQUEST sense to be retryable From: James Bottomley To: Mike Snitzer Cc: "Martin K. Petersen" , linux-scsi@vger.kernel.org, Hannes Reinecke , linux-kernel@vger.kernel.org Date: Mon, 13 Feb 2012 14:38:53 -0500 In-Reply-To: <20120213193615.GA10349@redhat.com> References: <1322857889-2623-1-git-send-email-snitzer@redhat.com> <20111206212704.GB30719@redhat.com> <20111206224218.GA31543@redhat.com> <20120213162923.GA29578@redhat.com> <20120213181359.GA5803@redhat.com> <20120213193615.GA10349@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 39 On Mon, 2012-02-13 at 14:36 -0500, Mike Snitzer wrote: > On Mon, Feb 13 2012 at 2:16pm -0500, > Martin K. Petersen wrote: > > > >>>>> "Mike" == Mike Snitzer writes: > > > > >> I don't have a fundamental problem with your patch. But since we > > >> explicitly handle ILLEGAL REQUEST with 0x20 and 0x24 in sd.c I wonder > > >> what's broken? We should disable discard support if the WRITE SAME w/ > > >> UNMAP fails. > > > > Mike> Yeah, I thought the disabling would be sufficient too. But > > Mike> unfortunately multipath doesn't inspect the request it is retrying > > Mike> (after it fails the path the request just failed on). > > > > Well, we shouldn't be returning something that multipath should ever act > > on. > > > > I think I understand what's going on. Can you try the following patch? > > Looks good to me (small nit below), it'll solve the immediate problem, > I'll pass it on. Please add my: > > Acked-by: Mike Snitzer > > But I also think establishing a baseline of TARGET_ERROR for certain > ILLEGAL REQUEST is still sane and should go in too... So someone still needs to package up the final agreed version with a nice changelog and send it to the list ... James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/