Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758803Ab2BNCmi (ORCPT ); Mon, 13 Feb 2012 21:42:38 -0500 Received: from mail-tul01m020-f174.google.com ([209.85.214.174]:48039 "EHLO mail-tul01m020-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251Ab2BNCme convert rfc822-to-8bit (ORCPT ); Mon, 13 Feb 2012 21:42:34 -0500 MIME-Version: 1.0 In-Reply-To: References: <20120213080618.GA11077@ponder.secretlab.ca> <20120213214623.GJ11077@ponder.secretlab.ca> <20120213.195835.1573147101037168145.davem@davemloft.net> From: Grant Likely Date: Mon, 13 Feb 2012 19:41:48 -0700 X-Google-Sender-Auth: Wt-XZwoiV9dM6AE44C-zwCav9Lw Message-ID: Subject: Re: OF-related boot crash in 3.3.0-rc3-00188-g3ec1e88 To: David Miller Cc: mroos@linux.ee, rob.herring@calxeda.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 31 On Mon, Feb 13, 2012 at 7:30 PM, Grant Likely wrote: > On Mon, Feb 13, 2012 at 5:58 PM, David Miller wrote: >> From: Grant Likely >> Date: Mon, 13 Feb 2012 14:46:23 -0700 >> >>> Ugh; that looks bad. ?If it failed there, then the global device node list >>> is corrupted. ?I hate to ask you this, but would you be able to git bisect to >>> narrow down the commit that causes the problem? >> >> Wild guess on all of these bugs, bad OF node reference counting and a >> OF node is free'd up prematurely. >> >> If you look at the sparc code that has been subsumed into the generic >> drivers/of/ stuff over the past few years, you'll see that we never >> consistently did any of the reference counting bits on the sparc side. > > Hmmm.... The of_node_put() code path shouldn't exist on sparc. ?You'll > see that it is #ifdef'd out in include/linux/of.h. ?Plus, only > 'OF_DETACHED' nodes are allowed to be released, an there are only 3 > code paths (all calling of_detach_node()) specific to powerpc that can > detach a node. In fact, I should disable those paths always when CONFIG_OF_DYNAMIC is disabled. I'll look into doing so for v3.4. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/