Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917Ab2BNFLG (ORCPT ); Tue, 14 Feb 2012 00:11:06 -0500 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:58359 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab2BNFLB (ORCPT ); Tue, 14 Feb 2012 00:11:01 -0500 X-AuditID: 9c930197-b7cdbae000001518-22-4f39ece15f10 Message-ID: <4F39ECDB.5090609@lge.com> Date: Tue, 14 Feb 2012 14:10:51 +0900 From: Namhyung Kim User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel To: Namhyung Kim CC: linux-kernel@vger.kernel.org, Ingo Molnar , Andi Kleen , Anshuman Khandual , Arun Sharma , Corey Ashford , David Ahern , Frederic Weisbecker , Jason Wang , Jiri Olsa , Joerg Roedel , Lin Ming , Paul Mackerras , Peter Zijlstra , Roberto Agostino Vitillo , Robert Richter , Stephane Eranian , Thomas Gleixner , Vince Weaver , arnaldo.melo@gmail.com, Arnaldo Carvalho de Melo Subject: Re: [GIT PULL 00/16] perf/core improvements and fixes References: <1329184375-27911-1-git-send-email-acme@infradead.org> <4F39CBE0.6050806@gmail.com> <4F39D00D.2060206@gmail.com> In-Reply-To: <4F39D00D.2060206@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3016 Lines: 88 2012-02-14 12:07 PM, Namhyung Kim wrote: > 2012-02-14 오전 11:50, Namhyung Kim 쓴 글: >> Hello, >> >> 2012-02-14 10:52 AM, Arnaldo Carvalho de Melo wrote: >>> The following changes since commit c98fdeaa92731308ed80386261fa2589addefa47: >>> >>> x86/sched/perf/AMD: Set sched_clock_stable (2012-02-07 13:12:08 +0100) >>> >>> are available in the git repository at: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-core-for-mingo >>> >>> for you to fetch changes up to 7e1ccd3804281fc0755eb726b654469c40a96d89: >>> >>> perf tools: cleanup initialization of attr->size (2012-02-13 23:35:04 -0200) >>> >>> ---------------------------------------------------------------- >>> perf/core fixes and improvements. >>> >>> Signed-off-by: Arnaldo Carvalho de Melo >>> >> >> I've got a following error during a simple test: >> >> $ ./perf record -- sleep 1 >> >> Error: sys_perf_event_open() syscall returned with 22 (Invalid argument). >> /bin/dmesg may provide additional information. >> >> Fatal: No CONFIG_PERF_EVENTS=y kernel support configured? >> >> sleep: Terminated >> >> >> Any thoughts? >> >> Thanks, >> Namhyung >> > > git bisect told me: > > c4a7dca92bbb9881a5d678720f1d0c2153499749 is the first bad commit > commit c4a7dca92bbb9881a5d678720f1d0c2153499749 > Author: Joerg Roedel > Date: Fri Feb 10 18:05:05 2012 +0100 > > perf tools: Change perf_guest default back to false > > Setting perf_guest to true by default makes no sense because the perf > subcommands can not setup guest symbol information and thus not process > and guest samples. The only exception is perf-kvm which changes the > perf_guest value on its own. So change the default for perf_guest back > to false. > > Cc: David Ahern > Cc: Ingo Molnar > Cc: Jason Wang > Cc: Paul Mackerras > Cc: Peter Zijlstra > Link: http://lkml.kernel.org/r/1328893505-4115-3-git-send-email-joerg.roedel@amd.com > Signed-off-by: Joerg Roedel > Signed-off-by: Arnaldo Carvalho de Melo > > :040000 040000 64d65944c9081dfd9ace65dbc19fca655cbdc708 4f0e86ab85314ba68f2295ae1e599f3bb5ab9484 M tools > > > Thanks, > Namhyung > It happened because I used old kernel version that isn't aware of the exclude_guest bit. So the check on attr->__reserved_1 in core.c::perf_copy_attr() failed and then ended up seeing EINVAL at perf_evsel__open(). So I think it should be handled in the same way of handling sample_id_all bit in perf record and top if we want to set perf_guest to false by default. I'll send patches for them soon. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/