Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759742Ab2BNJtB (ORCPT ); Tue, 14 Feb 2012 04:49:01 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:38748 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756480Ab2BNJs7 (ORCPT ); Tue, 14 Feb 2012 04:48:59 -0500 Date: Tue, 14 Feb 2012 09:48:35 +0000 From: Russell King - ARM Linux To: Ryan Mallon Cc: Nicolas Ferre , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, grant.likely@secretlab.ca, avictor.za@gmail.com, tglx@linutronix.de, plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/9] ARM: at91/snapper9260: move gpio_to_irq out of structure initialization Message-ID: <20120214094835.GB13673@n2100.arm.linux.org.uk> References: <1329144189-4535-1-git-send-email-nicolas.ferre@atmel.com> <4F396C4C.9060108@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F396C4C.9060108@gmail.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 18 On Tue, Feb 14, 2012 at 07:02:20AM +1100, Ryan Mallon wrote: > On 14/02/12 01:43, Nicolas Ferre wrote: > > > gpio_to_irq() implementation will be moved from a macro to a > > plain function: we cannot use it in a structure initialization > > anymore. > > What was the reason for the change? It was originally a macro for > exactly this reason. gpio_to_irq() is supposed to work not only for built-in GPIOs, but also GPIOs provided by other devices. Having it as a definition which only works for the SoC GPIOs is broken. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/