Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760424Ab2BNNTm (ORCPT ); Tue, 14 Feb 2012 08:19:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30524 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756203Ab2BNNTj (ORCPT ); Tue, 14 Feb 2012 08:19:39 -0500 Message-ID: <4F3A5F0B.2090309@redhat.com> Date: Tue, 14 Feb 2012 15:18:03 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Frederic Weisbecker CC: "Paul E. McKenney" , Christoph Lameter , Peter Zijlstra , Gilad Ben-Yossef , linux-kernel@vger.kernel.org, Chris Metcalf , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Sasha Levin , Rik van Riel , Andi Kleen , Mel Gorman , Andrew Morton , Alexander Viro , Michal Nazarewicz , Kosaki Motohiro , Milton Miller Subject: Re: [v7 0/8] Reduce cross CPU IPI interference References: <4F2AB66C.2030309@redhat.com> <20120202170134.GM2518@linux.vnet.ibm.com> <4F2AC69B.7000704@redhat.com> <20120202175155.GV2518@linux.vnet.ibm.com> <4F2E7311.8060808@redhat.com> <20120205165927.GH2467@linux.vnet.ibm.com> <20120209152155.GA22552@somewhere.redhat.com> <4F33EEB3.4080807@redhat.com> <20120209182216.GG22552@somewhere.redhat.com> <20120209234144.GC2458@linux.vnet.ibm.com> <20120210013911.GM22552@somewhere.redhat.com> In-Reply-To: <20120210013911.GM22552@somewhere.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 24 On 02/10/2012 03:39 AM, Frederic Weisbecker wrote: > > > > As long as the code doesn't enter RCU read-side critical sections in > > the time between rcu_idle_enter() and rcu_idle_exit(), this should > > work fine. > > This should work fine yeah but further the correctness, I wonder if this > is going to be a win. > > We use rcu_idle_enter() in idle to avoid to keep the tick for RCU. But > what about falling into guest mode? I guess the tick is kept there > so is it going to be a win in throughput or something to use rcu_idle_enter()? We could disable the tick while in guest mode as well. Interrupts in guest mode are even more expensive than interrupts in user mode. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/