Date: Tue, 14 Feb 2012 09:03:36 -0600 (CST)
From: Christoph Lameter <cl@linux.com>
To: Yang Bai <hamo.by@gmail.com>
cc: penberg@kernel.org, mpm@selenic.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: warning if total alloc size overflow
In-Reply-To: <1329204499-2671-1-git-send-email-hamo.by@gmail.com>
Message-ID: <alpine.DEB.2.00.1202140902400.20013@router.home>
References: <1329204499-2671-1-git-send-email-hamo.by@gmail.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 727
Lines: 18

On Tue, 14 Feb 2012, Yang Bai wrote:

> Before, if the total alloc size is overflow,
> we just return NULL like alloc fail. But they
> are two different type problems. The former looks
> more like a programming problem. So add a warning
> here.

Acked-by: Christoph Lameter <cl@linux.com>

Would be better to remove kcalloc and provide a generalized array size
calculation function that does the WARN(). That would also work for all
other variants zeroed or NUMA node spec etc etc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/