Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1329219673-28711-21-git-send-email-matt@console-pimps.org>
References: <1329219673-28711-21-git-send-email-matt@console-pimps.org> <1329219673-28711-1-git-send-email-matt@console-pimps.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: dhowells@redhat.com, linux-arch@vger.kernel.org,
        Oleg Nesterov <oleg@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Matt Fleming <matt.fleming@intel.com>,
        Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
        Al Viro <viro@zeniv.linux.org.uk>, linux-am33-list@redhat.com
Subject: Re: [PATCH 20/40] mn10300: Use set_current_blocked() and block_sigmask()
Date: Tue, 14 Feb 2012 15:56:16 +0000
Message-ID: <17603.1329234976@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 668
Lines: 19

Matt Fleming <matt@console-pimps.org> wrote:

>  asmlinkage long sys_sigsuspend(int history0, int history1, old_sigset_t mask)
>  {
> -	mask &= _BLOCKABLE;
> -	spin_lock_irq(&current->sighand->siglock);
> +	sigset_t blocked;
> +
>  	current->saved_sigmask = current->blocked;

Can this line create a race, now that it's not protected by a lock?  It is
possible for current->blocked to get altered by another thread.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/