Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779Ab2BNRx0 (ORCPT ); Tue, 14 Feb 2012 12:53:26 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:33087 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914Ab2BNRxZ (ORCPT ); Tue, 14 Feb 2012 12:53:25 -0500 Date: Tue, 14 Feb 2012 09:53:19 -0800 From: Tejun Heo To: Oleg Nesterov Cc: Andrew Morton , Anton Vorontsov , "Eric W. Biederman" , Greg KH , KOSAKI Motohiro , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] signal: give SEND_SIG_FORCED more power to beat SIGNAL_UNKILLABLE Message-ID: <20120214175319.GR12117@google.com> References: <20120210200004.GA20890@redhat.com> <20120210200021.GA20898@redhat.com> <20120210212532.GL19392@google.com> <20120214174528.GA23562@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120214174528.GA23562@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 18 On Tue, Feb 14, 2012 at 06:45:28PM +0100, Oleg Nesterov wrote: > > How about the following indentation instead? :) > > > > if (!prepare_signal(sig, t, > > from_ancestor_ns || (info == SEND_SIG_FORCED))) > > Well, I am not sure this looks better, although I do not really mind. > But since this patch is already in -mm, I think I won't send v2 ;) Yeah, they are different but equally ugly, I suppose. :) -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/