Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760779Ab2BNUO5 (ORCPT ); Tue, 14 Feb 2012 15:14:57 -0500 Received: from terminus.zytor.com ([198.137.202.10]:43806 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760635Ab2BNUOz (ORCPT ); Tue, 14 Feb 2012 15:14:55 -0500 Message-ID: <4F3AC0B4.1020203@intel.com> Date: Tue, 14 Feb 2012 12:14:44 -0800 From: "H. Peter Anvin" Organization: Intel Corporation User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: David Howells CC: Tony Luck , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Arnd Bergmann Subject: Re: [PATCH 21/21] posix_types: Remove fd_set macros References: <4F32A98F.7030400@zytor.com> <1328677745-20121-22-git-send-email-hpa@zytor.com> <1328677745-20121-1-git-send-email-hpa@zytor.com> <8328.1328703626@redhat.com> <16325.1328736262@redhat.com> <4F32E98F.2090909@zytor.com> <30935.1329247114@redhat.com> <4F3AB99E.5040705@zytor.com> In-Reply-To: <4F3AB99E.5040705@zytor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 27 On 02/14/2012 11:44 AM, H. Peter Anvin wrote: > > We can do that, but we'd almost certainly have to #include > in . The following macros are defined in > and *exported to userspace*: > > #define NFDBITS __NFDBITS > > #define FD_SETSIZE __FD_SETSIZE > #define FD_SET(fd,fdsetp) __FD_SET(fd,fdsetp) > #define FD_CLR(fd,fdsetp) __FD_CLR(fd,fdsetp) > #define FD_ISSET(fd,fdsetp) __FD_ISSET(fd,fdsetp) > #define FD_ZERO(fdsetp) __FD_ZERO(fdsetp) > Note: yes, those macros are completely useless, obviously, since all they do is take what is already defined in userspace and reflect it back out. Still, removing them is a userspace-visible change and really should be its own change with nothing else. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/