Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761426Ab2BOBFN (ORCPT ); Tue, 14 Feb 2012 20:05:13 -0500 Received: from sr-smtp.usish.com ([210.5.144.203]:58802 "EHLO sr-smtp.usish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757525Ab2BOBFK (ORCPT ); Tue, 14 Feb 2012 20:05:10 -0500 From: "Jack Wang" To: "'Danny Kukawka'" , "'James E.J. Bottomley'" Cc: "'Danny Kukawka'" , , , References: <1329230455-27084-1-git-send-email-danny.kukawka@bisect.de> Subject: RE: [PATCH] pm8001: fix enum checks Date: Wed, 15 Feb 2012 09:02:51 +0800 Message-ID: <19540A16097A409F9E4999160E0B25BC@usish.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <1329230455-27084-1-git-send-email-danny.kukawka@bisect.de> Thread-Index: AczrJqn7tKKCDKGGRrif2UpLYLTFzAAVrDIg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2011 Lines: 52 Thanks for fix. Acked-by: Jack Wang [PATCH] pm8001: fix enum checks > > Fix for: > drivers/scsi/pm8001/pm8001_hwi.c: In function 'hw_event_sas_phy_up': > drivers/scsi/pm8001/pm8001_hwi.c:2932:32: warning: comparison between > 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] > drivers/scsi/pm8001/pm8001_hwi.c:2934:37: warning: comparison between > 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] > > Changed SAS_END_DEV to SAS_END_DEVICE and NO_DEVICE with > SAS_PHY_UNUSED. > > Signed-off-by: Danny Kukawka > --- > drivers/scsi/pm8001/pm8001_hwi.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm8001_hwi.c > b/drivers/scsi/pm8001/pm8001_hwi.c > index b7b92f7..46fd7219 100644 > --- a/drivers/scsi/pm8001/pm8001_hwi.c > +++ b/drivers/scsi/pm8001/pm8001_hwi.c > @@ -2929,9 +2929,9 @@ hw_event_sas_phy_up(struct pm8001_hba_info *pm8001_ha, > void *piomb) > phy->phy_type |= PORT_TYPE_SAS; > phy->identify.device_type = deviceType; > phy->phy_attached = 1; > - if (phy->identify.device_type == SAS_END_DEV) > + if (phy->identify.device_type == SAS_END_DEVICE) > phy->identify.target_port_protocols = SAS_PROTOCOL_SSP; > - else if (phy->identify.device_type != NO_DEVICE) > + else if (phy->identify.device_type != SAS_PHY_UNUSED) > phy->identify.target_port_protocols = SAS_PROTOCOL_SMP; > phy->sas_phy.oob_mode = SAS_OOB_MODE; > sas_ha->notify_phy_event(&phy->sas_phy, PHYE_OOB_DONE); > -- > 1.7.7.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/