Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761435Ab2BOBJl (ORCPT ); Tue, 14 Feb 2012 20:09:41 -0500 Received: from mail-qw0-f53.google.com ([209.85.216.53]:41011 "EHLO mail-qw0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761351Ab2BOBJi convert rfc822-to-8bit (ORCPT ); Tue, 14 Feb 2012 20:09:38 -0500 MIME-Version: 1.0 In-Reply-To: <20120214181245.GS12117@google.com> References: <20120214181245.GS12117@google.com> Date: Wed, 15 Feb 2012 09:09:37 +0800 X-Google-Sender-Auth: N2FDvpXB2XE_9SP3elO-Hw799gQ Message-ID: Subject: Re: [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags From: Shaohua Li To: Tejun Heo Cc: Jens Axboe , Vivek Goyal , lkml , Knut Petersen , mroos@linux.ee, Linus Torvalds Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 23 2012/2/15 Tejun Heo : > icq->changed was used for ICQ_*_CHANGED bits. ?Rename it to flags and > access it under ioc->lock instead of using atomic bitops. > ioc_get_changed() is added so that the changed part can be fetched and > cleared as before. > > icq->flags will be used to carry other flags. > > Signed-off-by: Tejun Heo > --- > Jens, these three patches are to fix the swap heavy workload > regression reported by Shaohua. > > Shaohua, I ended up changing the second patch, which shouldn't change > anything but it would be great if you can verify this series once > more. yes, confirmed the patches fix the regression. Thanks for fixing it. Tested-by: Shaohua Li -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/