Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757749Ab2BOGPW (ORCPT ); Wed, 15 Feb 2012 01:15:22 -0500 Received: from mail-qw0-f53.google.com ([209.85.216.53]:62326 "EHLO mail-qw0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757Ab2BOGPT convert rfc822-to-8bit (ORCPT ); Wed, 15 Feb 2012 01:15:19 -0500 MIME-Version: 1.0 In-Reply-To: <201202070205.07589.rjw@sisk.pl> References: <201202070200.55505.rjw@sisk.pl> <201202070205.07589.rjw@sisk.pl> Date: Tue, 14 Feb 2012 22:15:18 -0800 Message-ID: Subject: Re: [RFC][PATCH 5/8] PM / Sleep: Change wakeup statistics From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: Linux PM list , LKML , Magnus Damm , markgross@thegnar.org, Matthew Garrett , Greg KH , John Stultz , Brian Swetland , Neil Brown , Alan Stern Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 24 On Mon, Feb 6, 2012 at 5:05 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Wakeup statistics used by Android are slightly different from what we > have at the moment, so modify them to follow Android more closely. ... > @@ -438,6 +444,11 @@ static void wakeup_source_deactivate(str > ? ? ? ?if (ktime_to_ns(duration) > ktime_to_ns(ws->max_time)) > ? ? ? ? ? ? ? ?ws->max_time = duration; > > + ? ? ? ws->last_time = now; > + ? ? ? if (ws->has_timeout && time_after(jiffies, ws->timer_expires)) time_after_eq may work better (or increment the count from the timer). I applied this patch and the expire counts I see for wakeup-sources that always time-out do not match the active count. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/