Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758061Ab2BOInv (ORCPT ); Wed, 15 Feb 2012 03:43:51 -0500 Received: from casper.infradead.org ([85.118.1.10]:37242 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758027Ab2BOInc (ORCPT ); Wed, 15 Feb 2012 03:43:32 -0500 Message-ID: <4F3B701F.6050703@kernel.dk> Date: Wed, 15 Feb 2012 09:43:11 +0100 From: Jens Axboe MIME-Version: 1.0 To: Shaohua Li CC: Tejun Heo , Vivek Goyal , lkml , Knut Petersen , mroos@linux.ee, Linus Torvalds Subject: Re: [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags References: <20120214181245.GS12117@google.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 31 On 2012-02-15 02:09, Shaohua Li wrote: > 2012/2/15 Tejun Heo : >> icq->changed was used for ICQ_*_CHANGED bits. Rename it to flags and >> access it under ioc->lock instead of using atomic bitops. >> ioc_get_changed() is added so that the changed part can be fetched and >> cleared as before. >> >> icq->flags will be used to carry other flags. >> >> Signed-off-by: Tejun Heo >> --- >> Jens, these three patches are to fix the swap heavy workload >> regression reported by Shaohua. >> >> Shaohua, I ended up changing the second patch, which shouldn't change >> anything but it would be great if you can verify this series once >> more. > yes, confirmed the patches fix the regression. Thanks for fixing it. > Tested-by: Shaohua Li Great, thanks Tejun - and Shaohua for finding/reporting/testing. I'll get this applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/