Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758056Ab2BOIoF (ORCPT ); Wed, 15 Feb 2012 03:44:05 -0500 Received: from anubis.se.axis.com ([195.60.68.12]:47089 "EHLO anubis.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757525Ab2BOIoB (ORCPT ); Wed, 15 Feb 2012 03:44:01 -0500 Date: Wed, 15 Feb 2012 09:43:54 +0100 From: Jesper Nilsson To: Matt Fleming Cc: "linux-arch@vger.kernel.org" , Oleg Nesterov , Andrew Morton , "linux-kernel@vger.kernel.org" , Matt Fleming , Mikael Starvik , linux-cris-kernel Subject: Re: [PATCH 08/40] cris: Use set_current_blocked() and block_sigmask() Message-ID: <20120215084354.GD8176@axis.com> References: <1329219673-28711-1-git-send-email-matt@console-pimps.org> <1329219673-28711-9-git-send-email-matt@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1329219673-28711-9-git-send-email-matt@console-pimps.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 33 On Tue, Feb 14, 2012 at 12:40:41PM +0100, Matt Fleming wrote: > From: Matt Fleming > > As described in e6fa16ab ("signal: sigprocmask() should do > retarget_shared_pending()") the modification of current->blocked is > incorrect as we need to check whether the signal we're about to block > is pending in the shared queue. > > Also, use the new helper function introduced in commit 5e6292c0f28f > ("signal: add block_sigmask() for adding sigmask to current->blocked") > which centralises the code for updating current->blocked after > successfully delivering a signal and reduces the amount of duplicate > code across architectures. In the past some architectures got this > code wrong, so using this helper function should stop that from > happening again. > > Cc: Oleg Nesterov > Cc: Mikael Starvik > Cc: Jesper Nilsson Acked-by: Jesper Nilsson > Cc: linux-cris-kernel@axis.com > Signed-off-by: Matt Fleming /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/