Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250Ab2BOL3J (ORCPT ); Wed, 15 Feb 2012 06:29:09 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:62465 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678Ab2BOL3H (ORCPT ); Wed, 15 Feb 2012 06:29:07 -0500 MIME-Version: 1.0 In-Reply-To: <4F3B17C7.9040107@ce.jp.nec.com> References: <4EE8E419.8010000@pre-sense.de> <20120214143800.69703df9@stein> <2173642.Y3HxI15Hxl@asus> <4F3B17C7.9040107@ce.jp.nec.com> Date: Wed, 15 Feb 2012 12:29:06 +0100 X-Google-Sender-Auth: PiqF6Xv9Wt6jmru-CcIK62fbarg Message-ID: Subject: Re: Yet another hot unplug NULL pointer dereference (was Re: status of oops in sd_revalidate_disk?) From: Bart Van Assche To: "Jun'ichi Nomura" Cc: Stefan Richter , jbottomley@parallels.com, linux-scsi@vger.kernel.org, Huajun Li , Axel Theilmann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 14 On Wed, Feb 15, 2012 at 3:26 AM, Jun'ichi Nomura wrote: > I think this patch is good, too. > Since QUEUE_FLAG_DEAD is also racy, it is not much different > from queuedata check, IMO. Are you sure ? As far as I know the block layer takes care of synchronizing queue flag modifications against request_fn invocations. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/