Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757266Ab2BOLuE (ORCPT ); Wed, 15 Feb 2012 06:50:04 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:47907 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754309Ab2BOLuB (ORCPT ); Wed, 15 Feb 2012 06:50:01 -0500 Subject: Re: [PATCH 20/40] mn10300: Use set_current_blocked() and block_sigmask() From: Matt Fleming To: David Howells Cc: linux-arch@vger.kernel.org, Oleg Nesterov , Andrew Morton , linux-kernel@vger.kernel.org, Koichi Yasutake , Al Viro , linux-am33-list@redhat.com In-Reply-To: <28189.1329244210@redhat.com> References: <1329242378.3675.71.camel@mfleming-mobl1.ger.corp.intel.com> <1329219673-28711-21-git-send-email-matt@console-pimps.org> <1329219673-28711-1-git-send-email-matt@console-pimps.org> <17603.1329234976@redhat.com> <28189.1329244210@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 15 Feb 2012 11:49:58 +0000 Message-ID: <1329306598.3675.115.camel@mfleming-mobl1.ger.corp.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 23 On Tue, 2012-02-14 at 18:30 +0000, David Howells wrote: > Matt Fleming wrote: > > > > Can this line create a race, now that it's not protected by a lock? It is > > > possible for current->blocked to get altered by another thread. > > > > ->blocked can only ever be altered by current, not another thread. See > > the following comment from sigprocmask() in kernel/signal.c, > > Okay, I've managed to convince myself. Feel free to my Acked-by to the > MN10300 and FRV patches. Thanks! I think Andrew is picking these up, unless you want to take them through the arch trees? -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/