Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756503Ab2BPBYQ (ORCPT ); Wed, 15 Feb 2012 20:24:16 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:42338 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751891Ab2BPBYL (ORCPT ); Wed, 15 Feb 2012 20:24:11 -0500 X-Authenticated: #10250065 X-Provags-ID: V01U2FsdGVkX18nf2oq92snSx3gEitMV+dm/0DSvL3chEOsIQq2Ci 1fLrVozCnH5mJl Message-ID: <4F3C5AAA.5040007@gmx.de> Date: Thu, 16 Feb 2012 01:23:54 +0000 From: Florian Tobias Schandinat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Icedove/3.0.11 MIME-Version: 1.0 To: Ondrej Zary CC: linux-fbdev@vger.kernel.org, Andrey Ulanov , Paul Mundt , Kernel development list Subject: Re: [PATCH v5] [resend] Resurrect Intel740 driver: i740fb References: <201202101859.27975.linux@rainbow-software.org> In-Reply-To: <201202101859.27975.linux@rainbow-software.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 51279 Lines: 1726 On 02/10/2012 05:59 PM, Ondrej Zary wrote: > This is a resurrection of an old (like 2.4.19) out-of-tree driver for > Intel740 graphics cards and adaptation for recent kernels. The old driver by > Andrey Ulanov is located at: http://sourceforge.net/projects/i740fbdev/files/ > > This is a new driver based on skeletonfb, using most of the low level HW code > from the old driver. The DDC code is completely new. > > The driver was tested on two 8MB cards: Protac AG240D and Diamond Stealth II > G460. > > Signed-off-by: Ondrej Zary Applied. Just for the record, checkpatch complained about WARNING: simple_strtoul is obsolete, use kstrtoul instead #1384: FILE: drivers/video/i740fb.c:1296: + mtrr = simple_strtoul(opt + 5, NULL, 0); Feel free to send another patch to fix it, if you like. Thanks, Florian Tobias Schandinat > --- > Changes in v5: > - fixed checkpatch problems > - added Kconfig dependency on FB_DDC > - cleaned up i740_calc_vclk() > - fixed SDRAM/SGRAM detection > - fixed wrong colors in 16bpp mode when neither 555 nor 565 specified > > --- linux-3.2.1-orig/drivers/video/Kconfig 2012-01-12 20:42:45.000000000 +0100 > +++ linux-3.2.1/drivers/video/Kconfig 2012-01-23 20:52:32.000000000 +0100 > @@ -1123,6 +1123,18 @@ config FB_RIVA_BACKLIGHT > help > Say Y here if you want to control the backlight of your display. > > +config FB_I740 > + tristate "Intel740 support (EXPERIMENTAL)" > + depends on EXPERIMENTAL && FB && PCI > + select FB_MODE_HELPERS > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + select VGASTATE > + select FB_DDC > + help > + This driver supports graphics cards based on Intel740 chip. > + > config FB_I810 > tristate "Intel 810/815 support (EXPERIMENTAL)" > depends on EXPERIMENTAL && FB && PCI && X86_32 && AGP_INTEL > --- linux-3.2.1-orig/drivers/video/Makefile 2012-01-12 20:42:45.000000000 +0100 > +++ linux-3.2.1/drivers/video/Makefile 2012-01-23 20:52:32.000000000 +0100 > @@ -37,6 +37,7 @@ obj-$(CONFIG_FB_GRVGA) += grv > obj-$(CONFIG_FB_PM2) += pm2fb.o > obj-$(CONFIG_FB_PM3) += pm3fb.o > > +obj-$(CONFIG_FB_I740) += i740fb.o > obj-$(CONFIG_FB_MATROX) += matrox/ > obj-$(CONFIG_FB_RIVA) += riva/ > obj-$(CONFIG_FB_NVIDIA) += nvidia/ > --- /dev/null 2012-01-24 00:06:39.330222901 +0100 > +++ linux-3.2.1/drivers/video/i740fb.c 2012-01-24 00:01:54.000000000 +0100 > @@ -0,0 +1,1337 @@ > +/* > + * i740fb - framebuffer driver for Intel740 > + * Copyright (c) 2011 Ondrej Zary > + * > + * Based on old i740fb driver (c) 2001-2002 Andrey Ulanov > + * which was partially based on: > + * VGA 16-color framebuffer driver (c) 1999 Ben Pfaff > + * and Petr Vandrovec > + * i740 driver from XFree86 (c) 1998-1999 Precision Insight, Inc., Cedar Park, > + * Texas. > + * i740fb by Patrick LERDA, v0.9 > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include