Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752982Ab2BPFfO (ORCPT ); Thu, 16 Feb 2012 00:35:14 -0500 Received: from mail-gy0-f174.google.com ([209.85.160.174]:44965 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837Ab2BPFfM convert rfc822-to-8bit (ORCPT ); Thu, 16 Feb 2012 00:35:12 -0500 MIME-Version: 1.0 In-Reply-To: <1329369930.5082.4.camel@joe2Laptop> References: <1329369296-4255-1-git-send-email-yinghai@kernel.org> <1329369296-4255-5-git-send-email-yinghai@kernel.org> <1329369930.5082.4.camel@joe2Laptop> Date: Wed, 15 Feb 2012 21:35:11 -0800 X-Google-Sender-Auth: CRZcWl_V1LUDrRMFjrrX5BYEH_4 Message-ID: Subject: Re: [PATCH 4/4] PCI: quirk print dev name with duration From: Yinghai Lu To: Joe Perches Cc: Jesse Barnes , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Arjan van de Ven Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 37 On Wed, Feb 15, 2012 at 9:25 PM, Joe Perches wrote: > On Wed, 2012-02-15 at 21:14 -0800, Yinghai Lu wrote: >> So could find out which device is involved with the calling > [] >> +++ linux-2.6/drivers/pci/quirks.c >> @@ -2854,14 +2854,15 @@ static void do_one_fixup_debug(void (*fn >> ? ? ? ktime_t calltime, delta, rettime; >> ? ? ? unsigned long long duration; >> >> - ? ? printk(KERN_DEBUG "calling ?%pF @ %i\n", fn, task_pid_nr(current)); >> + ? ? printk(KERN_DEBUG "calling ?%pF @ %i for %s\n", >> + ? ? ? ? ? ? ? ? ? ? fn, task_pid_nr(current), dev_name(&dev->dev)); > > Might be better to use dev_dbg > > ? ? ? ?dev_dbg(&dev->dev, "calling %pF @ %i\n", fn, task_pid_nr(current)); > > [] > >> - ? ? printk(KERN_DEBUG "pci fixup %pF returned after %lld usecs\n", fn, >> - ? ? ? ? ? ? duration); >> + ? ? printk(KERN_DEBUG "pci fixup %pF returned after %lld usecs for %s\n", >> + ? ? ? ? ? ? ? ? ? ? fn, duration, dev_name(&dev->dev)); > > ? ? ? ?dev_dbg(&dev->dev, "pci fixup %pF returned after %llu usecs\n", > ? ? ? ? ? ? ? ?fn, duration); Not sure if that is going to break Arjan 's tool that analyze the boot time. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/