Message-ID: <4F3CD2A2.3010700@bootc.net>
Date: Thu, 16 Feb 2012 09:55:46 +0000
From: Chris Boot <bootc@bootc.net>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1
MIME-Version: 1.0
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
CC: linux1394-devel@lists.sourceforge.net, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, agrover@redhat.com, clemens@ladisch.de,
        nab@linux-iscsi.org
Subject: Re: [PATCH v2 04/11] firewire-sbp-target: Add sbp_base.h header
References: <1328989452-20921-1-git-send-email-bootc@bootc.net> <1329317248-94128-1-git-send-email-bootc@bootc.net> <1329317248-94128-5-git-send-email-bootc@bootc.net> <20120215201509.37949cb0@stein>
In-Reply-To: <20120215201509.37949cb0@stein>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1643
Lines: 60

On 15/02/2012 19:15, Stefan Richter wrote:
> On Feb 15 Chris Boot wrote:
>> --- /dev/null
>> +++ b/drivers/target/sbp/sbp_base.h
>> @@ -0,0 +1,204 @@
> [...]
>> +struct sbp2_pointer {
>> +	__be32 high;
>> +	__be32 low;
>> +};
> [...]
>> +struct sbp_tport {
>> +	/* Target Unit Identifier (EUI-64) */
>> +	u64 guid;
>> +	/* Target port name */
>> +	char tport_name[SBP_NAMELEN];
>> +	/* Returned by sbp_make_tport() */
>> +	struct se_wwn tport_wwn;
>> +
>> +	struct sbp_tpg *tpg;
>> +
>> +	/* FireWire unit directory */
>> +	struct fw_descriptor unit_directory;
>> +
>> +	/* SBP Management Agent */
>> +	struct sbp_management_agent *mgt_agt;
>> +
>> +	/* Parameters */
>> +	int enable;
>> +	s32 directory_id;
>> +	int mgt_orb_timeout;
>> +	int max_reconnect_timeout;
>> +	int max_logins_per_lun;
>> +};
>> +
>> +extern struct target_fabric_configfs *sbp_fabric_configfs;
>> +extern const struct fw_address_region sbp_register_region;
>> +extern struct workqueue_struct *sbp_workqueue;
> [...]
>
> Generally, any source file (.c or .h) is meant to be self-contained WRT
> type definitions etc., meaning that they should have all required
> #include's in themselves rather than rely on indirect includes.
>
> So here you should include the headers which define __be32, u64, struct
> se_wwn, struct workqueue and so on.

Thanks. I'll work on fixing this.

Cheers,
Chris

-- 
Chris Boot
bootc@bootc.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/