Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919Ab2BPNqx (ORCPT ); Thu, 16 Feb 2012 08:46:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34557 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779Ab2BPNqv (ORCPT ); Thu, 16 Feb 2012 08:46:51 -0500 From: Jan Kara To: LKML Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Eric Sandeen , Dave Chinner , Jan Kara , Steve French , linux-cifs@vger.kernel.org Subject: [PATCH 05/11] cifs: Push file_update_time() into cifs_page_mkwrite() Date: Thu, 16 Feb 2012 14:46:13 +0100 Message-Id: <1329399979-3647-6-git-send-email-jack@suse.cz> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1329399979-3647-1-git-send-email-jack@suse.cz> References: <1329399979-3647-1-git-send-email-jack@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 32 CC: Steve French CC: linux-cifs@vger.kernel.org Signed-off-by: Jan Kara --- fs/cifs/file.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) BTW: How does cifs_page_mkwrite() protect against races with truncate? See e.g. checks in __block_page_mkwrite()... diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 4dd9283..8e3b23b 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -2425,6 +2425,9 @@ cifs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) { struct page *page = vmf->page; + /* Update file times before taking page lock */ + file_update_time(vma->vm_file); + lock_page(page); return VM_FAULT_LOCKED; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/