Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613Ab2BPPdl (ORCPT ); Thu, 16 Feb 2012 10:33:41 -0500 Received: from mail.free-electrons.com ([88.190.12.23]:43231 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134Ab2BPPdk (ORCPT ); Thu, 16 Feb 2012 10:33:40 -0500 Message-ID: <4F3D21C8.8020301@free-electrons.com> Date: Thu, 16 Feb 2012 16:33:28 +0100 From: Michael Opdenacker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: Olexiy Avramchenko CC: linux-arm-kernel@lists.arm.linux.org.uk, Linux Kernel Mailing List Subject: Re: [PATCH 2/2] ARM: add support for xz kernel decompression References: <1329404057-26346-1-git-send-email-michael.opdenacker@free-electrons.com> <1329404057-26346-3-git-send-email-michael.opdenacker@free-electrons.com> In-Reply-To: X-Enigmail-Version: 1.3.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 36 Hi Olexiy, Thanks for the code review! On 02/16/2012 04:13 PM, Olexiy Avramchenko wrote: > Hi, Michael > > Spotted minor typo (I guess): > >> -extra-y += piggy.gzip piggy.lzo piggy.lzma lib1funcs.S $(libfdt) $(libfdt_hdrs) >> +extra-y += piggy.gzip piggy.lzo piggy.lzma piggy.xz lib1funcs.S $(libfdt) $(libfdt_hdrs) > Shouldn't it be piggy.xzkern here? I'd also stick with *.xz as on x86, > but that's probably not so important. You're right, that should be piggy.xzkern indeed, as this is the file that is generated. Unless we make more changes, we have to stick to this filename, because 'xzkern' is also the command that's called to compress the kernel image. I will post an update soon. Thanks again, Michael. -- Michael Opdenacker, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com +33 484 253 396 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/