Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754795Ab2BPTBX (ORCPT ); Thu, 16 Feb 2012 14:01:23 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:12336 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943Ab2BPTBU convert rfc822-to-8bit (ORCPT ); Thu, 16 Feb 2012 14:01:20 -0500 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Thu, 16 Feb 2012 11:01:18 -0800 From: Stephen Warren To: Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" CC: Shawn Guo , Thomas Abraham , Dong Aisheng , Rajendra Nayak , Haojian Zhuang , Barry Song <21cnbao@gmail.com>, Tony Lindgren , "linux-serial@vger.kernel.org" Date: Thu, 16 Feb 2012 11:01:17 -0800 Subject: RE: [PATCH] serial/sirf: fixup for changes to pin control Thread-Topic: [PATCH] serial/sirf: fixup for changes to pin control Thread-Index: Aczs2vfEPBF+96NhRmefQf8gIGJbpAAAf4Dw Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1790EC8791@HQMAIL01.nvidia.com> References: <1329417828-6005-1-git-send-email-linus.walleij@linaro.org> In-Reply-To: <1329417828-6005-1-git-send-email-linus.walleij@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 29 Linus Walleij wrote at Thursday, February 16, 2012 11:44 AM: > We changed the signature of the pin multiplexing functions to > handle any pin business, so fix up the Sirf driver to call this > new interface and rename some variables to make the semantics > understandable. > > Cc: linux-serial@vger.kernel.org > Signed-off-by: Linus Walleij Looks good to me for now. I'll have to do another similar change when I implement the pinctrl_get API changes we discussed at Linaro Connect (I should start implementing that today), but I guess that's no big deal. Should this patch be put into the pinctrl tree since that's where the API changed, perhaps even squashed into the original commit to avoid git bisect breakage, unless your branch needs to be stable? Otherwise, this change will conflict with my future similar change if pulled for the same kernel version. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/