Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032Ab2BQILQ (ORCPT ); Fri, 17 Feb 2012 03:11:16 -0500 Received: from smtprelay05.ispgateway.de ([80.67.31.100]:40676 "EHLO smtprelay05.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730Ab2BQILP (ORCPT ); Fri, 17 Feb 2012 03:11:15 -0500 Message-ID: <4F3E0C3D.4030307@ladisch.de> Date: Fri, 17 Feb 2012 09:13:49 +0100 From: Clemens Ladisch User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1 MIME-Version: 1.0 To: "Alex,Shi" CC: Sarah Sharp , stern@rowland.harvard.edu, Greg KH , linux-usb@vger.kernel.org, andiry.xu@amd.com, linux-kernel@vger.kernel.org, Oliver Neukum , Takashi Iwai , trenn@suse.de, linux-pci@vger.kernel.org, Michal Marek Subject: Re: [PATCH] usb: enable pci MSI/MSIX in usb core References: <1328531341-22705-1-git-send-email-alex.shi@intel.com> <4F311233.9070404@intel.com> <20120207144204.GA7214@kroah.com> <20120207172743.GA4780@xanatos> <20120207221317.GA6103@xanatos> <1328664392.12669.233.camel@debian> <1328682430.12669.443.camel@debian> <1328692300.12669.593.camel@debian> <20120214002030.GA10364@xanatos> <1329359801.12669.2872.camel@debian> <1329461087.12669.2911.camel@debian> In-Reply-To: <1329461087.12669.2911.camel@debian> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Df-Sender: bGludXgtdXNiQGNsLmRvbWFpbmZhY3Rvcnkta3VuZGUuZGU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 31 Alex,Shi wrote: > On Thu, 2012-02-16 at 10:36 +0800, Alex,Shi wrote: >>>> +/* msi irq handler should be here, if driver has */ >>>> +irqreturn_t hcd_msi_irq(int irq, struct usb_hcd *hcd) >>>> +{ >>>> + return hcd->driver->irq(hcd); >>>> +} >>> >>> This works for now, but it isn't going to work in the future. We need >>> the USB core to provide us with the irq number so we can map the MSI-X >>> interrupt to the event ring that generated the interrupt, whenever we >>> get around to adding multiple event rings. >> >> Do you mean to add 2 new vectors for MSI/MSIX in hc_driver? > > + irqreturn_t (*msi_irq) (struct usb_hcd *hcd); > + irqreturn_t (*msix_irq) (struct usb_hcd *hcd); The controller driver will need to know which of the multiple MSI-X interrupts has been raised: irqreturn_t (*msix_irq)(struct usb_hcd *hcd, unsigned int nr_or_index); Regards, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/