Message-ID: <1329491708.2293.277.camel@twins>
Subject: Re: [PATCH 1/2] rmap: Staticize page_referenced_file and
 page_referenced_anon
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Hugh Dickins <hughd@google.com>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        Mel Gorman <mgorman@suse.de>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Date: Fri, 17 Feb 2012 16:15:08 +0100
In-Reply-To: <1329488869-7270-1-git-send-email-consul.kautuk@gmail.com>
References: <1329488869-7270-1-git-send-email-consul.kautuk@gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 805
Lines: 20

On Fri, 2012-02-17 at 09:27 -0500, Kautuk Consul wrote:
> Staticize the page_referenced_anon and page_referenced_file
> functions.
> These functions are called only from page_referenced.

Subject and changelog say: staticize, which I read to mean: make static.
Yet what the patch does is make them inline ?!?

Also, if they're static and there's only a single callsite, gcc will
already inline them, does this patch really make a difference?

> -static int page_referenced_anon(struct page *page,
> +static inline int page_referenced_anon(struct page *page,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/