Message-ID: <1329504344.584.18.camel@joe2Laptop>
Subject: Re: [PATCH] Cleaning up code formatting errors in net/wireless
 pointed out by checkpatch.
From: Joe Perches <joe@perches.com>
To: Luis Felipe Strano Moraes <lfelipe@profusion.mobi>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net, davem@davemloft.net,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 17 Feb 2012 10:45:44 -0800
In-Reply-To: <1329492603-3972-1-git-send-email-lfelipe@profusion.mobi>
References: <1329492603-3972-1-git-send-email-lfelipe@profusion.mobi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1113
Lines: 36

On Fri, 2012-02-17 at 07:30 -0800, Luis Felipe Strano Moraes wrote:
> These are mostly minor changes and they are being sent as one patch only in
> order to cause the smallest amount of disruption.
[]
> diff --git a/net/wireless/core.c b/net/wireless/core.c
[]
> @@ -668,7 +668,7 @@ void wiphy_unregister(struct wiphy *wiphy)
>  		mutex_lock(&rdev->devlist_mtx);
>  		__count = rdev->opencount;
>  		mutex_unlock(&rdev->devlist_mtx);
> -		__count == 0;}));
> +		__count == 0; }));

Inline statement expressions are pretty unusual
for kernel sources.  Normally these are used via
macro.

I'd try to make the statement expression visually
distinct.  Something like:

	wait_event(rdev->dev_wait,
		   ({
			   int __count;
			   mutex_lock(&rdev->devlist_mtx);
			   __count = rdev->opencount;
			   mutex_unlock(&rdev->devlist_mtx);
			   __count == 0;
		   })
		  );


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/