Date: Fri, 17 Feb 2012 13:46:04 -0800 (PST)
From: Hugh Dickins <hughd@google.com>
To: Matthew Garrett <mjg@redhat.com>
cc: Holger Macht <holger@homac.de>, Jeff Garzik <jgarzik@redhat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>, linux-kernel@vger.kernel.org
Subject: linux-next: dock_link_device is oopsy
Message-ID: <alpine.LSU.2.00.1202171320590.5994@eggly.anvils>
User-Agent: Alpine 2.00 (LSU 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1072
Lines: 24

Matthew,

A linux-next oops at bootup in dock_link_device() tells me that you
were not feeling well when you wrote that and dock_unlink_device():
I hope you're feeling better now and can rewrite them soon.

I think my particular problem comes from dock_station_count 0,
so kmalloc() returns NULL, which you don't check for.  But those
functions appear to be minor masterpieces of doing things in the
wrong order, not checking allocation, not freeing resource on failure.

I'm not attaching a proposed patch because, on that record, I bet when
you look closer you'll find more wrong that I wouldn't know about.

Let's hope this isn't diverted into an endless discussion of whether
you ought to use kaalloc() or kballoc() or ....  me, I'd just like to
boot, and have put #if 0..#endif around everything in those functions.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/