Date: Sun, 19 Feb 2012 18:59:56 -0500 (EST)
Message-Id: <20120219.185956.2140542911171040902.davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: thomas@m3y3r.de, linux-kernel@vger.kernel.org, jcliburn@gmail.com,
        chris.snook@gmail.com, netdev@vger.kernel.org, jwboyer@gmail.com
Subject: Re: [PATCH] atl1c: dont use highprio tx queue
From: David Miller <davem@davemloft.net>
In-Reply-To: <1329374591.5646.23.camel@edumazet-laptop>
References: <1329373082.5646.9.camel@edumazet-laptop>
	<21390AB8-BD9B-44D7-B2CE-B20AF7605CE7@m3y3r.de>
	<1329374591.5646.23.camel@edumazet-laptop>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1050
Lines: 28

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 16 Feb 2012 07:43:11 +0100

> This driver attempts to use two TX rings but lacks proper support :
> 
> 1) IRQ handler only takes care of TX completion on first TX ring
> 2) the stop/start logic uses the legacy functions (for non multiqueue
> drivers)
> 
> This means all packets witk skb mark set to 1 are sent through high
> queue but are never cleaned and queue eventualy fills and block the
> device, triggering the infamous "NETDEV WATCHDOG" message. 
> 
> Lets use a single TX ring to fix the problem, this driver is not a real
> multiqueue one yet.
> 
> Minimal fix for stable kernels.
> 
> Reported-by: Thomas Meyer <thomas@m3y3r.de>
> Tested-by: Thomas Meyer <thomas@m3y3r.de>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/