Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615Ab2BTA4e (ORCPT ); Sun, 19 Feb 2012 19:56:34 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35207 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225Ab2BTA4c (ORCPT ); Sun, 19 Feb 2012 19:56:32 -0500 MIME-Version: 1.0 In-Reply-To: <1329696488-16970-9-git-send-email-hpa@zytor.com> References: <1329696488-16970-1-git-send-email-hpa@zytor.com> <1329696488-16970-9-git-send-email-hpa@zytor.com> From: Linus Torvalds Date: Sun, 19 Feb 2012 16:56:11 -0800 X-Google-Sender-Auth: KpuOn4E9eaCvCrT57KXFJC9xbGg Message-ID: Subject: Re: [PATCH 08/30] compat: Use COMPAT_USE_64BIT_TIME in the lp driver To: "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, akpm@linux-foundation.org, hjl.tools@gmail.com, Arnd Bergmann , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 25 On Sun, Feb 19, 2012 at 4:07 PM, H. Peter Anvin wrote: > From: "H. J. Lu" > > Enable the lp driver to be used with a compat ABI with 64-bit time. Ugh. Is this really the only case? Because if it isn't, I suspect it would be much better off with a helper function. In fact, even if this *does* end up being the only place, a helper function to get/set a timeval from user space sounds like a good idea, and makes things much more readable than that ad-hoccery in the middle of code. IOW, I'd like to see something like get_user_timeval(void __user *tv, struct timeval *res) even if it would be only local to this file. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/