Message-ID: <1329735073.2293.305.camel@twins>
Subject: Re: [RFC PATCH 0/4] Gang scheduling in CFS
From: Peter Zijlstra <peterz@infradead.org>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, Avi Kivity <avi@redhat.com>,
        Rik van Riel <riel@redhat.com>, linux-kernel@vger.kernel.org,
        vatsa@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com
Date: Mon, 20 Feb 2012 11:51:13 +0100
In-Reply-To: <87fwe6ork3.fsf@abhimanyu.in.ibm.com>
References: <20111230095147.GA10543@elte.hu>
	 <878vlu4bgh.fsf@linux.vnet.ibm.com> <87pqf5mqg4.fsf@abhimanyu.in.ibm.com>
	 <4F017AD2.3090504@redhat.com> <87mxa3zqm1.fsf@abhimanyu.in.ibm.com>
	 <4F046536.5080207@redhat.com> <4F048295.1050907@redhat.com>
	 <4F04898B.1080600@redhat.com> <1325712710.3084.10.camel@laptop>
	 <4F04C789.40209@redhat.com> <20120105091059.GA3249@elte.hu>
	 <87fwe6ork3.fsf@abhimanyu.in.ibm.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 771
Lines: 17

On Mon, 2012-02-20 at 13:38 +0530, Nikunj A Dadhania wrote:
> +#ifdef CONFIG_PARAVIRT_FLUSH_TLB
> +               while (!cpumask_empty(to_cpumask(f->flush_cpumask)) && --loop)
> +                       cpu_relax();
> +               if (!loop && !cpumask_empty(to_cpumask(f->flush_cpumask)))
> +                       halt();


That's just vile, you don't need to wait for it, all you need to make
sure is that when that vcpu wakes up it does the flush.

But yeah, the results are a good hint that you're on the right track.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/