Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753315Ab2BTOYh (ORCPT ); Mon, 20 Feb 2012 09:24:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36271 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190Ab2BTOYf (ORCPT ); Mon, 20 Feb 2012 09:24:35 -0500 Message-ID: <4F42579F.5070701@suse.cz> Date: Mon, 20 Feb 2012 15:24:31 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Arnaud Lacombe Cc: Randy Dunlap , Geert Uytterhoeven , Andrew Morton , Konstantin Khlebnikov , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Sam Ravnborg , linux-kbuild@vger.kernel.org Subject: Re: [PATCH] mm: add config NUMA stub to all architectures References: <4F3E42E0.4030108@openvz.org> <20120217120815.25909.15632.stgit@zurg> <20120217123037.ecfc5dd9.akpm@linux-foundation.org> <4F413B8D.5080307@xenotime.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 33 On 20.2.2012 00:21, Arnaud Lacombe wrote: > On Sun, Feb 19, 2012 at 1:12 PM, Randy Dunlap wrote: >> On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote: >>> >>> On Fri, Feb 17, 2012 at 21:30, Andrew Morton >>> wrote: >>>> It would be better to teach IS_ENABLED() to handle this situation. I >>>> don't think there's a way of doing this with cpp :( >>>> >>>> This limitation makes IS_ENABLED pretty dangerous, doesn't it? It >>>> makes it very easy to introduce build breakage with unexpected Kconfig >>>> combinations. >>> >>> >>> Indeed. Recently I discovered IS_ENABLED() and started recommending it >>> to people for new code. But now I've seen the CONFIG_NUMA breakage, >>> I no longer think this is a good recommendation. >> >> adding Michal & linux-kbuild to cc: list. >> > I do not really see any way to fix this, beside having a unique > architecture-wide configuration namespace :/ Having a single namespace, or less ambitiously, having less arch-specific config symbol definitions, would be a plus. IS_ENABLED requiring the symbol to be defined is not bad per se, it prevents typos. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/