Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696Ab2BTPmG (ORCPT ); Mon, 20 Feb 2012 10:42:06 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53433 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291Ab2BTPmF (ORCPT ); Mon, 20 Feb 2012 10:42:05 -0500 Date: Mon, 20 Feb 2012 07:41:55 -0800 From: Mark Brown To: Arnd Bergmann Cc: Samuel Ortiz , Ashish Jangam , linux-kernel@vger.kernel.org, Dajun Subject: Re: [PATCH 01/01] MFD: add ADC support to DA9052/53 MFD core v2 Message-ID: <20120220154151.GA3258@opensource.wolfsonmicro.com> References: <1326465051.3542.334.camel@dhruva> <20120220114420.GT5387@sortiz-mobl> <201202201207.27510.arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <201202201207.27510.arnd@arndb.de> X-Cookie: You'll be sorry... User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2168 Lines: 50 --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 20, 2012 at 12:07:27PM +0000, Arnd Bergmann wrote: > Also, I would recommend using request_irq instead of request_threaded_irq > here because the function only has a single "complete()" call in it, > just like a threaded IRQ handler has. There is no point going through > another thread just to wake up the one that is blocked. Actually in this case that won't work as the interrupt is generated by the chip interrupt controller and as the chip is I2C/SPI controlled it is itself threaded and can only generate threaded interrupts as genirq can't get back into hard interrupt context. As a result of this restriction when an interrupt handler doesn't care what context it runs in it's better to use request_any_context_irq(). This will do a normal IRQ when it can but will bind successfully to a threaded IRQ if that's what's provided. --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPQmm4AAoJEBus8iNuMP3d9JcP/iIFlRE5djix2NBuCrCEFQy2 36Nhu4PNy5wExn6s9rBsy4R+y98f9soxuHzNGVqbFrxQluNKbm5GHOqnPkvUgBic uWvjkgxiKmlt0knBPI8ckVSJAGCppVnJELZ0+rLMwtfBatkcVPoHXitBTVs1PR+9 CKhO43S2sQ9I+MKigGOp8b4CsNQ6r0HQWrUq/VPjKqBBW2iNmI5uDIZGwsckr6MV uSj+i2WXmaQujJtFFnhkXo4ZBDFza/bdDI4Jko39OJj+bSwHqrznu22n+AsoxJsT YSe7x5Devf4xrbzccQMrpFxjpV+LwfF2P9nTiqYPrJegvZW8vitfATefm5YFs/5M bNCYMHjLPNjDODw0GjYg46dwQJOdsVeg9A3tqEvouhLAmS2HoU3fssJAW8fKl6U3 rUTFlkQVEMEAwUyKuSOS7kSdJ5Oc8viA9AMYGyl7CCtbik012YOK33fRjb9x8jdn 6aKnTV0d9HVgeMg8WD75HpqIwunG2yqbQetTJSlEG/ipq8g0U8F1rVWfhkWPBiDa mrZLiQ5JbsXbb89sRras9NsC8s31Wj4zMGHy9vkOxCv+6yIkrEZVlLBQVhmLsCT2 zHSX0mVHm5x/5UjATfYvE2WpVxdvTR1190eJeSXhBoQZ+UlSdisf0K+gNE7rhF9V UuFTypt5QUW5TQcPZZyt =Zx7W -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/