Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823Ab2BTQL5 (ORCPT ); Mon, 20 Feb 2012 11:11:57 -0500 Received: from casper.infradead.org ([85.118.1.10]:52983 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753730Ab2BTQL4 convert rfc822-to-8bit (ORCPT ); Mon, 20 Feb 2012 11:11:56 -0500 Message-ID: <1329754301.2293.358.camel@twins> Subject: Re: [RFC PATCH 14/14] sched: implement usage tracking From: Peter Zijlstra To: Paul Turner Cc: linux-kernel@vger.kernel.org, Venki Pallipadi , Srivatsa Vaddagiri , Mike Galbraith , Kamalesh Babulal , Ben Segall , Ingo Molnar , Vaidyanathan Srinivasan Date: Mon, 20 Feb 2012 17:11:41 +0100 In-Reply-To: References: <20120202013825.20844.26081.stgit@kitami.mtv.corp.google.com> <20120202013827.20844.49057.stgit@kitami.mtv.corp.google.com> <1329399446.2293.217.camel@twins> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 22 On Fri, 2012-02-17 at 02:54 -0800, Paul Turner wrote: > On Thu, Feb 16, 2012 at 5:37 AM, Peter Zijlstra wrote: > > On Wed, 2012-02-01 at 17:38 -0800, Paul Turner wrote: > >> static inline void update_rq_runnable_avg(struct rq *rq, int runnable) > >> { > >> - __update_entity_runnable_avg(rq->clock_task, &rq->avg, runnable); > >> + __update_entity_runnable_avg(rq->clock_task, &rq->avg, runnable, > >> + runnable); > > > > Its not immediately obvious why we use @runnable for @running, > > Isn't it? An rq is the root of all scheduling -- if there are any > runnable tasks than one of them better be running when this is called. > > I can add a comment to this effect. Ah, indeed. Yes a comment would be good ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/