Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940Ab2BTQz5 (ORCPT ); Mon, 20 Feb 2012 11:55:57 -0500 Received: from mga11.intel.com ([192.55.52.93]:12324 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447Ab2BTQz4 (ORCPT ); Mon, 20 Feb 2012 11:55:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="119399505" Date: Mon, 20 Feb 2012 18:03:06 +0100 From: Samuel Ortiz To: Mark Brown Cc: Liam Girdwood , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mfd: Add __devinit and __devexit annotations in wm8994 Message-ID: <20120220170306.GF5387@sortiz-mobl> References: <1327327172-8411-1-git-send-email-broonie@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327327172-8411-1-git-send-email-broonie@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 26 Hi Mark, On Mon, Jan 23, 2012 at 01:59:30PM +0000, Mark Brown wrote: > The wm8994_device_init() and wm8994_device_exit() functions were not > annotated as device init and exit functions, meaning they shouldn't > reference __devinitdata. > > Signed-off-by: Mark Brown > --- > > This is mostly just a warning fix for the second patch and doesn't seem > terribly critical otherwise so it should probably get merged along with > it. Fine with me as well. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/