MIME-Version: 1.0
In-Reply-To: <1329720360-23227-5-git-send-email-swarren@nvidia.com>
References: <1329720360-23227-1-git-send-email-swarren@nvidia.com>
	<1329720360-23227-5-git-send-email-swarren@nvidia.com>
Date: Mon, 20 Feb 2012 22:15:21 +0100
Message-ID: <CACRpkdYCkRrvt+2B2nzAR+4XTeZo=N+OVA49TuExHCwsLAExwg@mail.gmail.com>
Subject: Re: [PATCH 04/20] pinctrl: Record a pin owner, not mux function, when
 requesting pins
From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Warren <swarren@nvidia.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>, B29396@freescale.com,
        s.hauer@pengutronix.de, dongas86@gmail.com, shawn.guo@linaro.org,
        thomas.abraham@linaro.org, tony@atomide.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1444
Lines: 38

On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren <swarren@nvidia.com> wrote:

> When pins are requested/acquired/got, some device becomes the owner of
> their mux setting. At this point, it isn't certain which mux function
> will be selected for the pin, since this may vary between each of the
> device's states in the pinctrl mapping table. As such, we should record
> the owning device, not what we think the initial mux setting will be,
> when requesting pins.
>
> This doesn't make a lot of difference right now since pinctrl_get gets
> only one single device/state combination, but this will make a difference
> when pinctrl_get gets all states, and pinctrl_select_state can switch
> between states.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Mostly a rename then, OK...

> @@ -66,19 +65,14 @@ static int pin_request(struct pinctrl_dev *pctldev,
> ? ? ? ? ? ? ? ?goto out;
> ? ? ? ?}
>
> - ? ? ? if (!function) {
> - ? ? ? ? ? ? ? dev_err(pctldev->dev, "no function name given\n");
> - ? ? ? ? ? ? ? return -EINVAL;
> - ? ? ? }
> -

Why should it be allowed to have a NULL owner? There is a
debug print involving it above but ... maybe this is over-cautious?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/